Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport fixes for GCC 8.1 #3510

Merged
merged 2 commits into from Sep 11, 2018
Merged

Backport fixes for GCC 8.1 #3510

merged 2 commits into from Sep 11, 2018

Conversation

tenderlove
Copy link
Contributor

@tenderlove tenderlove commented Jul 27, 2018

Hi,

This PR just backports abcminiuser/lufa@d8e0d67 and abcminiuser/lufa@a08a024 so that QMK compiles with avr-gcc 8.1.

Before this PR, I would get:

Compiling: lib/lufa/LUFA/Drivers/USB/Class/Device/AudioClassDevice.c                               In file included from lib/lufa/LUFA/Drivers/USB/Class/Device/AudioClassDevice.c:38:
lib/lufa/LUFA/Drivers/USB/Class/Device/AudioClassDevice.h:382:10: error: 'EVENT_Audio_Device_StreamStartStop' alias between functions of incompatible types 'void(USB_ClassInfo_Audio_Device_t * const)' {aka 'void(struct <anonymous> * const)'} and 'void(void)' [-Werror=attribute-alias]
     void EVENT_Audio_Device_StreamStartStop(USB_ClassInfo_Audio_Device_t* const AudioInterfaceInfo)
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
lib/lufa/LUFA/Drivers/USB/Class/Device/AudioClassDevice.c:191:6: note: aliased declaration here
 void Audio_Device_Event_Stub(void)
      ^~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
 [ERRORS]
 | 
 | 
 | 
make[1]: *** [.build/obj_planck_light_tenderlove/lib/lufa/LUFA/Drivers/USB/Class/Device/AudioClassDevice.o] Error 1
make: *** [planck/light:tenderlove] Error 1
Make finished with errors

After this PR everything seems to compile. I think this also fixes #3316

Refs: abcminiuser/lufa#130

@evantravers
Copy link
Contributor

If this gets approved and merged, we should probably revert this PR: #3337

@carlf
Copy link

carlf commented Sep 11, 2018

I merged this into my local copy and it fixed all my build problems on arch.

@skullydazed skullydazed merged commit df8e417 into qmk:master Sep 11, 2018
@skullydazed
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

planck/light:default doesn't compile with avr-gcc (GCC) 8.1.0 (LUFA errors)
6 participants