AMJ96 Refactor and Configurator update #3707
Conversation
LAYOUT matrix and default keymap refactored to use full-length keycodes (instead of shorthand).
Minor physical layout update and made the labels more sensible.
White space correction.
Disabled the following options as my local test compile's .hex ended up too big to fit in the available flash space: MOUSEKEY_ENABLE EXTRAKEY_ENABLE BACKLIGHT_ENABLE RGBLIGHT_ENABLE If this is undesirable, suggestions are welcome.
keyboards/amj96/amj96.h
Outdated
| @@ -18,25 +18,28 @@ | |||
|
|
|||
| #include "quantum.h" | |||
|
|
|||
| // readability | |||
| #define ___ KC_NO | |||
There was a problem hiding this comment.
I think we typically have KC_NO shorthanded as rather than shorter spaces as it can be misread as a KC_TRNS which has 7 spaces.
There was a problem hiding this comment.
I think this should be fine, as most people don't go looking in the keyboard files for stuff.
There was a problem hiding this comment.
I use ___ for KC_NO in keyboard.h files because I find it easier to spot at a glance than XXX, because the switch identifiers are shorter length.
I do stick with the standard usage for keymap.c though.
There was a problem hiding this comment.
i think my issue is more the fact that there are two shorthands for it. People who don't know the code quite as well will think the spaces is KC_TRNS. Can we agree on one form of shorthand or atleast document that ___ is KC_NO and _______ is KC_TRNS.
keyboards/amj96/rules.mk
Outdated
| FAUXCLICKY_ENABLE = no # Use buzzer to emulate clicky switches | ||
| NKRO_ENABLE ?= yes # USB Nkey Rollover | ||
| BACKLIGHT_ENABLE ?= no # Enable keyboard backlight functionality on B7 by default | ||
| RGBLIGHT_ENABLE = no |
There was a problem hiding this comment.
I'd like to keep both lighting options turned on as we have no way to "turn it on" via the configurator this way. Also BACKLIGHT_ENABLE = yes should be sufficient. No need to put that ? in.
There was a problem hiding this comment.
Turning off COMMAND would be safer, I think, as that will save a good deal of space.
There was a problem hiding this comment.
oh yes COMMAND is better!
There was a problem hiding this comment.
@mechmerlin I left the question mark because it was already there, and I didn't know what the difference was between = and ?= other than knowing there was one until five minutes ago.
Will disable COMMAND_ENABLE (saves about 3 KB in my local compile).
|
@noroadsleft to save space, it may be best to turn off the COMMAND functionality, since that uses a lot of space. #define NO_ACTION_MACRO
#define NO_ACTION_FUNCTIONWorst case, it may help to add |
Re-enabled MOUSEKEY_ENABLE, EXTRAKEY_ENABLE, BACKLIGHT_ENABLE, and RGBLIGHT_ENABLE and disabled COMMAND_ENABLE in rules.mk; enabled NO_ACTION_MACRO and NO_ACTION_FUNCTION per @drashna
|
Thanks! |
* AMJ96 Refactor LAYOUT matrix and default keymap refactored to use full-length keycodes (instead of shorthand). * Configurator update Minor physical layout update and made the labels more sensible. * Readme update White space correction. * Default keymap update: #include QMK_KEYBOARD_H * rules.mk update Disabled the following options as my local test compile's .hex ended up too big to fit in the available flash space: MOUSEKEY_ENABLE EXTRAKEY_ENABLE BACKLIGHT_ENABLE RGBLIGHT_ENABLE If this is undesirable, suggestions are welcome. * Config/rules update Re-enabled MOUSEKEY_ENABLE, EXTRAKEY_ENABLE, BACKLIGHT_ENABLE, and RGBLIGHT_ENABLE and disabled COMMAND_ENABLE in rules.mk; enabled NO_ACTION_MACRO and NO_ACTION_FUNCTION per @drashna * Swapped `___` for `XXX` in amj96.h per @mechmerlin
* AMJ96 Refactor LAYOUT matrix and default keymap refactored to use full-length keycodes (instead of shorthand). * Configurator update Minor physical layout update and made the labels more sensible. * Readme update White space correction. * Default keymap update: #include QMK_KEYBOARD_H * rules.mk update Disabled the following options as my local test compile's .hex ended up too big to fit in the available flash space: MOUSEKEY_ENABLE EXTRAKEY_ENABLE BACKLIGHT_ENABLE RGBLIGHT_ENABLE If this is undesirable, suggestions are welcome. * Config/rules update Re-enabled MOUSEKEY_ENABLE, EXTRAKEY_ENABLE, BACKLIGHT_ENABLE, and RGBLIGHT_ENABLE and disabled COMMAND_ENABLE in rules.mk; enabled NO_ACTION_MACRO and NO_ACTION_FUNCTION per @drashna * Swapped `___` for `XXX` in amj96.h per @mechmerlin
* AMJ96 Refactor LAYOUT matrix and default keymap refactored to use full-length keycodes (instead of shorthand). * Configurator update Minor physical layout update and made the labels more sensible. * Readme update White space correction. * Default keymap update: #include QMK_KEYBOARD_H * rules.mk update Disabled the following options as my local test compile's .hex ended up too big to fit in the available flash space: MOUSEKEY_ENABLE EXTRAKEY_ENABLE BACKLIGHT_ENABLE RGBLIGHT_ENABLE If this is undesirable, suggestions are welcome. * Config/rules update Re-enabled MOUSEKEY_ENABLE, EXTRAKEY_ENABLE, BACKLIGHT_ENABLE, and RGBLIGHT_ENABLE and disabled COMMAND_ENABLE in rules.mk; enabled NO_ACTION_MACRO and NO_ACTION_FUNCTION per @drashna * Swapped `___` for `XXX` in amj96.h per @mechmerlin
* AMJ96 Refactor LAYOUT matrix and default keymap refactored to use full-length keycodes (instead of shorthand). * Configurator update Minor physical layout update and made the labels more sensible. * Readme update White space correction. * Default keymap update: #include QMK_KEYBOARD_H * rules.mk update Disabled the following options as my local test compile's .hex ended up too big to fit in the available flash space: MOUSEKEY_ENABLE EXTRAKEY_ENABLE BACKLIGHT_ENABLE RGBLIGHT_ENABLE If this is undesirable, suggestions are welcome. * Config/rules update Re-enabled MOUSEKEY_ENABLE, EXTRAKEY_ENABLE, BACKLIGHT_ENABLE, and RGBLIGHT_ENABLE and disabled COMMAND_ENABLE in rules.mk; enabled NO_ACTION_MACRO and NO_ACTION_FUNCTION per @drashna * Swapped `___` for `XXX` in amj96.h per @mechmerlin
AMJ96 Refactor
LAYOUT matrix and default keymap refactored to use full-length keycodes (instead of shorthand).
Configurator update
Minor physical layout update and made the labels more sensible.
Readme update
White space correction.
Default keymap update: #include QMK_KEYBOARD_H
rules.mk update
Disabled the following options as my local test compile's .hex ended up too big to fit in the available flash space:
If this is undesirable, suggestions are welcome.