Added my keymap for Rorschach keyboard; minor updates to my Kinesis files. #3734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tuesdayjohn
changed the title
drashna
requested changes
Aug 25, 2018
| #ifndef CONFIG_USER_H | ||
| #define CONFIG_USER_H | ||
|
|
||
| #include "config_common.h" |
There was a problem hiding this comment.
This line isn't actually needed.
| @@ -0,0 +1,30 @@ | |||
|
|
|||
| #ifndef CONFIG_USER_H | |||
There was a problem hiding this comment.
If you could remove the ifndef and define blocks (as well as the endif at the end) and replace it with #pragma once?
| SLEEP_LED_ENABLE = no # Breathing sleep LED during USB suspend | ||
| TAP_DANCE_ENABLE = yes # Enable Tap Dancing function | ||
|
|
||
| ifndef QUANTUM_DIR |
There was a problem hiding this comment.
This ifndef block isn't needed, and is a holdover from the old makefile system.
|
Changes have been added. |
drashna
approved these changes
Aug 25, 2018
|
Thanks! |
alexey-danilov
pushed a commit
to alexey-danilov/qmk_firmware
that referenced
this pull request
Sep 6, 2018
…inesis files. (qmk#3734) * Added keymap for Rorschach * Rorschach update * Minor updates to Kinesis files * Minor fixes * Minor fixes for Rorschach
dstrelau
pushed a commit
to dstrelau/qmk_firmware
that referenced
this pull request
Sep 7, 2018
* master: (691 commits) mitosis: minor readme improvements (qmk#3762) add linebreaks to "Keyboard Maintainer:..." blocks where missing (qmk#3763) Keymap: Made changes to buswerks ortho_4x12 keymap (qmk#3757) Keyboard: Putting all my ducks in a row: Lightsaver (qmk#3758) Keyboard: Make a 1upkeyboards directory for visibility (qmk#3759) Helpful functions Keymap: initial migration of raffle planck (qmk#3748) Keyboard: Duck Jetfire QMK Support (qmk#3752) Keymap: initial migration of raffle 1up60rgb (qmk#3747) Keymap: PyroL Let's Split keymap + Alpha keymap modifications (qmk#3753) Keyboard: Change the default LAYOUT to LAYOUT_60_hhkb for tokyo60 (qmk#3751) Keyboard: Tokyo60 Cleanup: QMK Configurator support (qmk#3749) Keyboard: add tokyo60 (qmk#2861) Keyboard: Added gamepad layout to cospad (qmk#3714) Keymap: Added my keymap for Rorschach keyboard; minor updates to my Kinesis files. (qmk#3734) Keyboard: readme.md update (qmk#3581) Keymap: update to budi's tv44 (qmk#3587) Keyboard: introduce new default layout 68_ansi (qmk#3745) Keymap: Hold for MO and Tap for TG (qmk#3742) Keyboard: add Wavelet (qmk#3739) ...
ChrissiQ
pushed a commit
to ChrissiQ/qmk_firmware
that referenced
this pull request
Sep 25, 2018
…inesis files. (qmk#3734) * Added keymap for Rorschach * Rorschach update * Minor updates to Kinesis files * Minor fixes * Minor fixes for Rorschach
yamad
pushed a commit
to yamad/qmk_firmware
that referenced
this pull request
Apr 10, 2019
…inesis files. (qmk#3734) * Added keymap for Rorschach * Rorschach update * Minor updates to Kinesis files * Minor fixes * Minor fixes for Rorschach
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added my keymap for Rorschach keyboard; minor updates to my Kinesis files.