Devided #3856, split Space Cadet process, trying fix at #3701 #3885

leico · 2018-09-09T18:13:14Z

update: 09/12/18

based on Improvement of Space Cadet Shift by preventing to automatically apply… #3856 pull requests.
split Space Cadet process from quantum/quantum.c to quantum/process_keycode/process_space_cadet.c/h
refactored Space Cadet process
- try to fix Space Cadet Shifts sends extraneous input with KC_GESC #3701
~~try to fix GRAVE_ESC with GUI sends GUI+GRAVE, wanting just GRAVE #3769~~
- ~~defined GESC_GR_IGNORED_MOD~~
- ~~defined GESC_GR_IGNORED_MOD_BIT~~

Todo:

… a modifier on the key and allow to override the default modifier. Closes qmk#3815

…egistering KC_LSFT when equals to LSPO_MOD

change #if to if statement

* GESC_GR_IGNORED_MOD * GESC_GR_IGNORED_MOD_BIT

drashna · 2018-09-10T03:25:41Z

I hate to ask....

But while you're doing this, would you mind adding something like NO_SPACE_CADET, so that this code can be completely removed, if desired?

leico · 2018-09-10T03:30:09Z

OK, will try it as soon as possible. No ploblem.

SCS_LEFT SCS_RIGHT

Space Cadet Shift enable when SPACE_CADET_ENABLE = yes is written in rules.mk

correspond * SPACE_CADET_ENABLE * GESC_GR_IGNORED_MOD * GESC_GR_IGNORED_MOD_BIT

skullydazed

We're still discussing the overall structure internally. In the meantime please see my comments above for changes we know you can make now.

docs/feature_grave_esc.md

docs/feature_space_cadet_shift.md

keyboards/alu84/keymaps/default/rules.mk

quantum/quantum.c

quantum/quantum_keycodes.h

revert docs/feature_grave_escape.md from before change grave_escape process

delete space between table symbol | revert quantum/quantum_keycodes.h

leico · 2018-09-12T03:05:57Z

conflicts in common_features.mk master adds dynamic_keymap space_cadet adds space_cadet both leave in common_features.mk

…ture

…s fall out layouts

… templates * rules.mk add SPACE_CADET_ENABLE = no commented around +520 bytes increase * documents * feature_space_cadet_shift.md * feature_space_cadet_shift_enter.md noted around +520 bytes increase

leico · 2018-10-23T14:04:30Z

@drashna , Thank you reply.

Perhaps all of space cadet used layouts would enable, also template goes disable default.
one more, compare binary size between enable and disable, noted in documents how many bytes increase when enable.

drashna · 2019-02-28T20:52:56Z

This PR and #5226 aim to do the same thing. Though, that PR includes some additional functionality.

leico · 2019-02-28T22:04:12Z

@drashna yes, It looks similar directionality enhancements, #5226 looks more multifunctional. I am still waiting a result about internal structure discussion. 4 month ago, I and @skullydazed afraid to QMK souces become a #define , #ifdef spagetti hell.

drashna · 2019-06-06T06:53:46Z

I hate to say it, but I think that the space cadet feature has been overhauled, and also meets most of the same goals that this PR had, plus more.

That's why there are a bunch of merge conflicts now.

I'm closing this for now. If you don't feel that's correct/appropriate, then please do re-open, and update your PR.

Anthony Richir and others added 10 commits September 5, 2018 15:29

Improvement of Space Cadet Shift by preventing to automatically apply…

34a708f

… a modifier on the key and allow to override the default modifier. Closes qmk#3815

Improve the use of the DISABLE_SPACE_CADET_MODIFIER flag to avoid unr…

afc189a

…egistering KC_LSFT when equals to LSPO_MOD

change #if to if statement

5c6f7b6

Merge pull request qmk#1 from leico/space_cadet

64a67a8

change #if to if statement

split space cadet functions from quantum.c to process_space_cadet.c

18bd520

scoop upped default setting in quantum.c

7b938b5

refactored space cadet process

3f4ae09

edit grave escape to set ignore modifier

13d5620

add selection for grave escape

db0352e

* GESC_GR_IGNORED_MOD * GESC_GR_IGNORED_MOD_BIT

fixed tapping term not defined

eda84a8

drashna requested review from jackhumbert, fredizzimo and skullydazed September 10, 2018 03:23

drashna added enhancement optimization labels Sep 10, 2018

leico added 8 commits September 10, 2018 19:56

changes magic number to enum

1212a51

SCS_LEFT SCS_RIGHT

add SPACE_CADET_ENABLE

a16a3c8

Space Cadet Shift enable when SPACE_CADET_ENABLE = yes is written in rules.mk

improve forgot #ifdef preprocessor in quantum.c

b8005d2

change space cadet process to strict

d54a763

adding space cadet flag in required keymaps rules.mk

c9dbdbb

Merge branch 'master' into space_cadet

6ba54ef

update each docs

0952a42

correspond * SPACE_CADET_ENABLE * GESC_GR_IGNORED_MOD * GESC_GR_IGNORED_MOD_BIT

improve incorrect information

7d7fbe3

skullydazed requested changes Sep 10, 2018

View reviewed changes

leico added 4 commits September 12, 2018 10:36

Merge branch 'master' into space_cadet

2ff1e14

revert docs/feature_grave_escape.md

2db461e

revert docs/feature_grave_escape.md from before change grave_escape process

revert grave escape process

a6b5e61

improve documentation, revert quantum/quantum_keycodes.h

1c03d1a

delete space between table symbol | revert quantum/quantum_keycodes.h

leico changed the title ~~Devided #3856, split Space Cadet process, trying fix at #3701 and #3769~~ Devided #3856, split Space Cadet process, trying fix at #3701 Sep 13, 2018

leico added 8 commits September 14, 2018 10:49

Merge branch 'master' into space_cadet

200059d

conflicts in common_features.mk master adds dynamic_keymap space_cadet adds space_cadet both leave in common_features.mk

Merge branch 'master' into space_cadet

5ce9b7b

Merge branch 'master' into space_cadet

7015a92

Merge branch 'master' into space_cadet

da2a1cb

Add SPACE_CADET_ENABLE = yes option which have already used those fea…

8a553c7

…ture

add SPACE_CADET_ENABLE = no in keyboard template

09fd90c

change SPACE_CADET_ENABLE = yes position, add SPACE_CADET_ENABLE = ye…

7a801a6

…s fall out layouts

edit keyboard templates rules.mk, add binary size info in documents /…

f468f55

… templates * rules.mk add SPACE_CADET_ENABLE = no commented around +520 bytes increase * documents * feature_space_cadet_shift.md * feature_space_cadet_shift_enter.md noted around +520 bytes increase

leico added 4 commits October 27, 2018 22:45

Merge branch 'master' into space_cadet

33db372

Merge branch 'master' into space_cadet

f178b81

add SPACE_CADET_ENABLE = yes they have already used LSPO, RSPC or SFTENT

bc22678

Merge branch 'master' into space_cadet

b50f078

drashna added duplicate core labels Feb 28, 2019

drashna mentioned this pull request Feb 28, 2019

Extended space cadet to support ctrl and alt #5226

Closed

13 tasks

drashna closed this Jun 6, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Devided #3856, split Space Cadet process, trying fix at #3701 #3885

Devided #3856, split Space Cadet process, trying fix at #3701 #3885

leico commented Sep 9, 2018 •

edited

drashna commented Sep 10, 2018

leico commented Sep 10, 2018 •

edited

skullydazed left a comment

leico commented Sep 12, 2018 •

edited

leico commented Oct 23, 2018

drashna commented Feb 28, 2019

leico commented Feb 28, 2019

drashna commented Jun 6, 2019

Devided #3856, split Space Cadet process, trying fix at #3701 #3885

Devided #3856, split Space Cadet process, trying fix at #3701 #3885

Conversation

leico commented Sep 9, 2018 • edited

drashna commented Sep 10, 2018

leico commented Sep 10, 2018 • edited

skullydazed left a comment

Choose a reason for hiding this comment

leico commented Sep 12, 2018 • edited

leico commented Oct 23, 2018

drashna commented Feb 28, 2019

leico commented Feb 28, 2019

drashna commented Jun 6, 2019

leico commented Sep 9, 2018 •

edited

leico commented Sep 10, 2018 •

edited

leico commented Sep 12, 2018 •

edited