Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relocate some common backlight functionally #7273

Merged
merged 1 commit into from
Jan 13, 2020
Merged

Relocate some common backlight functionally #7273

merged 1 commit into from
Jan 13, 2020

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Nov 5, 2019 •
edited

Description

Part 1 of N:

  • Remove duplication of breathing config
    • Had to use weak as a bunch of boards are doing custom backlight without setting the rules.mk flag
  • Remove duplication of cie_lightness
  • Relocate backlight function definitions from quantum to backlight

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr added the core label Nov 5, 2019
@zvecr zvecr requested a review from a team November 5, 2019 21:08
@zvecr zvecr changed the title Relocate common backlight functionally Relocate some common backlight functionally Nov 6, 2019
@zvecr zvecr marked this pull request as ready for review November 6, 2019 00:23
@zvecr zvecr changed the title Relocate some common backlight functionally [WIP] Relocate some common backlight functionally Nov 6, 2019
drashna
drashna approved these changes Nov 6, 2019
View reviewed changes
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Cleans up quantum a lot, which is nice!

@zvecr zvecr changed the title [WIP] Relocate some common backlight functionally Relocate some common backlight functionally Nov 7, 2019
@stale
Copy link

stale bot commented Dec 22, 2019

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@zvecr zvecr requested review from drashna and a team December 23, 2019 19:51
@zvecr
Copy link
Member Author

zvecr commented Dec 23, 2019

Rebased, removed moving of cie_lightness for now to avoid conflict with #7521

@zvecr zvecr mentioned this pull request Dec 29, 2019
Merged
13 tasks
@zvecr zvecr merged commit b89e35b into qmk:master Jan 13, 2020
@zvecr zvecr mentioned this pull request Jan 13, 2020
Merged
13 tasks
drashna pushed a commit to zsa/qmk_firmware that referenced this pull request Feb 12, 2020
@zvecr @drashna
Relocate common backlight functionally (qmk#7273)
0cd94d5
fdidron pushed a commit to zsa/qmk_firmware that referenced this pull request Feb 14, 2020
@zvecr @fdidron
Relocate common backlight functionally (qmk#7273)
5bd553e
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Feb 21, 2020
@zvecr @HokieGeek
Relocate common backlight functionally (qmk#7273)
d5784c4
fdidron pushed a commit to zsa/qmk_firmware that referenced this pull request Feb 26, 2020
@zvecr @fdidron
Relocate common backlight functionally (qmk#7273)
060244a
kylekuj pushed a commit to kylekuj/qmk_firmware that referenced this pull request Apr 21, 2020
@zvecr @kujawakk
Relocate common backlight functionally (qmk#7273)
bdfc6a6
@zvecr zvecr deleted the feature/backlight_unify branch April 28, 2020 00:56
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@zvecr
Relocate common backlight functionally (qmk#7273)
66d5f92
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Duckle29 Duckle29 Duckle29 approved these changes

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna Awaiting requested review from drashna

Assignees
No one assigned
Labels
awaiting review core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zvecr @drashna @Duckle29 @fauxpark