Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Keyboard] Add Exclusive E7-V1 SE keyboard and keymaps #7598

Merged
merged 1 commit into from Dec 13, 2019

Conversation

briemens
Copy link
Contributor

@briemens briemens commented Dec 10, 2019

This week I received my E7-V1 SE with a new type of PCB, different from the original E7-V1.

e7v1se

Exclusive published the hex and json files for the new PCB on geekhack

Following MechMerlin's video I created a new profile plus two basic keymaps.

Please merge for the other group buy members to use.

Thanks!

BTW. I'm currently typing on a working firmware build based on the configuration of this commit.

keyboards/exclusive/e7v1se/e7v1se.c Show resolved Hide resolved
keyboards/exclusive/e7v1se/keymaps/default/config.h Outdated Show resolved Hide resolved
keyboards/exclusive/e7v1se/keymaps/mac/config.h Outdated Show resolved Hide resolved
keyboards/exclusive/e7v1se/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/exclusive/e7v1se/readme.md Outdated Show resolved Hide resolved
keyboards/exclusive/e7v1se/readme.md Outdated Show resolved Hide resolved
keyboards/exclusive/e7v1se/readme.md Outdated Show resolved Hide resolved
keyboards/exclusive/e7v1se/rules.mk Outdated Show resolved Hide resolved
keyboards/exclusive/e7v1se/info.json Outdated Show resolved Hide resolved
@fauxpark fauxpark requested a review from a team December 10, 2019 23:33
@briemens
Copy link
Contributor Author

Thanks @fauxpark and @drashna for your feedback. Tomorrow I will clean up the code and push an update for review.

@briemens
Copy link
Contributor Author

@fauxpark and @drashna I processed your feedback. 👍 Thanks again for your insights.
I squashed the original and the commit with your processed feedback into a single commit. Hopefully ready for being merged so other E7-V1 SE users that are receiving their boards can start making their own keymaps. 😃

Copy link
Contributor Author

@briemens briemens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the comments and feedback have been processed. Hopefully this PR can be merged into master. 🙏

Copy link
Member

@fauxpark fauxpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@fauxpark fauxpark merged commit ab78386 into qmk:master Dec 13, 2019
patrl pushed a commit to patrl/qmk_firmware that referenced this pull request Dec 29, 2019
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants