Add VIA support to MxSS, plus minor tweaks #7809
Conversation
|
@Wilba6582 If you could check over the VIA implementation here, it'd be much appreciated. |
|
I followed the method that @awkannan did for the Satisfaction75 here, so things should align with the intended implementation. |
There was a problem hiding this comment.
The EEPROM handling could be refactored to be closer to how I did it during the VIA refactor, examples: keyboards\cannonkeys\stm32f072\keyboard.c , keyboards\wilba_tech\wt_main.c.
i.e. if VIA not enabled, matrix_init_kb() calls via_init() which calls via_eeprom_*() functions.
|
Advice followed. |
|
👍 |
Given that #4915 targets old via code, and isnt merged. I dont think we should be adding the mentioned handlers unless they work out of the box right now. |
|
They work out of the box. My work was to update it to extend on the commit to support more of the API. |
|
Oh, if the concern was whether my VIA API is up to date, I was referred to that PR by olivia who asked me to test if it worked, and it does out of the box. The current VIA implementation expects the keyboard to handle backlight related functions, and I pulled the list of API calls from the VIA repo (though they have not been updated since anyhow). |
|
@MxBlu I gave my 👍 before all this RGB stuff. We are working on a generalized implementation for the QMK RGB (bottom LEDs and/or matrix). It would make more sense to wait for this, than end up in another situation where I have to refactor other people's code to make it continue to work in VIA. |
|
A shame, but alright. Will revert the merge, but leave my code up on https://github.com/MxBlu/qmk_firmware/tree/mxss-via-backlight. |
Only thing not working is alternating, but that's not too important
|
Alright, this lot of changes is just a cherrypick from the backlight branch, which updates my rgblight.c to the current one, and merges in my changes. Also has some quality of life things like shifting over the front LED code to another source file, and moving some parts of color storage to EEPROM in prep for being able to add in VIA RGB support in the future. I apologise for it being a bit overwhelming, but tidying it now will make it easier in the future. |
|
@fauxpark Changes have been addressed. |
|
Anything more to be done to get this merged in? |
|
Can I please get some feedback/get this merged...? |
|
Given that Wilba, Fauxpark, and Drashna have all approved, I’d say this is good to merge. |
* Add VIA support to mxss and general cleanup * Add support for RGB test for FLEDs * Add LAYOUT_all to allow for more configuration * Remove blank layers * Updated readme * Improve use of EEPROM * Credit where its due * Use the latest iteration of rgblight code * Keep the RGB timer running if the front LED is in RGB mode * Fix RGB breathing animation * Better supported RGB animation Only thing not working is alternating, but that's not too important * Abstract front LED handlers from main kb code * Add support for indicator LED color changing * Remove debug statement * Persist indicator LED colors * Mark custom sections in rgblight.c * Light commenting * Fix up keymaps * Add/update comments * Remove bloat from default hex * Tidy a stray tab * Out with the old, in with the new * Out with the old, in with the new * Add LAYER_STATE_8BIT for VIA keymap
* Add VIA support to mxss and general cleanup * Add support for RGB test for FLEDs * Add LAYOUT_all to allow for more configuration * Remove blank layers * Updated readme * Improve use of EEPROM * Credit where its due * Use the latest iteration of rgblight code * Keep the RGB timer running if the front LED is in RGB mode * Fix RGB breathing animation * Better supported RGB animation Only thing not working is alternating, but that's not too important * Abstract front LED handlers from main kb code * Add support for indicator LED color changing * Remove debug statement * Persist indicator LED colors * Mark custom sections in rgblight.c * Light commenting * Fix up keymaps * Add/update comments * Remove bloat from default hex * Tidy a stray tab * Out with the old, in with the new * Out with the old, in with the new * Add LAYER_STATE_8BIT for VIA keymap
* Add VIA support to mxss and general cleanup * Add support for RGB test for FLEDs * Add LAYOUT_all to allow for more configuration * Remove blank layers * Updated readme * Improve use of EEPROM * Credit where its due * Use the latest iteration of rgblight code * Keep the RGB timer running if the front LED is in RGB mode * Fix RGB breathing animation * Better supported RGB animation Only thing not working is alternating, but that's not too important * Abstract front LED handlers from main kb code * Add support for indicator LED color changing * Remove debug statement * Persist indicator LED colors * Mark custom sections in rgblight.c * Light commenting * Fix up keymaps * Add/update comments * Remove bloat from default hex * Tidy a stray tab * Out with the old, in with the new * Out with the old, in with the new * Add LAYER_STATE_8BIT for VIA keymap
As it says on the label. Added a universal layout, did a bit of cleanup and added support for RGB Test effect mode while I was at it. Those changes are like only a few lines long, which is why I've combined them into this one, I hope that's alright.
VIA PR: the-via/keyboards#20
Types of Changes
Checklist