Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial work for consolidation of ChibiOS platform files #8327

Merged
merged 8 commits into from Jun 6, 2020
Merged

Initial work for consolidation of ChibiOS platform files #8327

merged 8 commits into from Jun 6, 2020

Conversation

tzarc
Copy link
Member

@tzarc tzarc commented Mar 6, 2020 •
edited

Description

Start of the consolidation work to move the ChibiOS board definitions as well as the default set of configuration files for existing board definitions used by keyboards.

  • Uses /platforms/chibios as previously discussed on discord.
  • Consolidates the Proton C configs into the generic F303 definitions.
  • Allows for defining a default set of chconf.h, halconf.h, and mcuconf.h files within the platform definition, which is able to be overridden by the keyboard directly, though include path ordering.
  • Adds template chconf.h, halconf.h, mcuconf.h, and board.h that can be dropped into a keyboard directory, in order to override rather than replace the entire contents of the respective files.
-------------------------------
Successful builds: 873
Warning builds: 20
Failing builds: 0
-------------------------------

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@tzarc tzarc requested a review from a team March 6, 2020 18:34
@tzarc
Copy link
Member Author

tzarc commented Mar 6, 2020

Ignore the init hook stuff for now, will be breaking it into a separate PR shortly.

@drashna drashna requested review from skullydazed and a team March 7, 2020 00:17
@tzarc
Copy link
Member Author

tzarc commented Mar 8, 2020

I think there's going to be some interaction with #8330, specifically with respect to how we deal with providing default configurations when boards are attempting to use the ChibiOS board definitions.

I believe that #8330 is worthwhile to go in without this consolidation work, as we can direct new ChibiOS-based keyboards to use the new APIs instead of duplicating boards.

@tzarc tzarc mentioned this pull request Mar 12, 2020
Merged
13 tasks
@tzarc tzarc force-pushed the platforms-chibios-refactor branch 2 times, most recently from ac8c529 to fd8e80f Compare March 12, 2020 21:55
@zvecr zvecr mentioned this pull request Mar 24, 2020
Merged
13 tasks
@tzarc tzarc force-pushed the platforms-chibios-refactor branch 7 times, most recently from 5d36915 to a834deb Compare April 28, 2020 01:45
@tzarc tzarc marked this pull request as ready for review April 28, 2020 01:48
@tzarc tzarc marked this pull request as draft April 28, 2020 02:41
@tzarc
Copy link
Member Author

tzarc commented Apr 28, 2020

Reverted to draft while I migrate the rest of the F401/F411 stuff.

@tzarc tzarc marked this pull request as ready for review April 28, 2020 03:03
@tzarc
Copy link
Member Author

tzarc commented Apr 28, 2020

F401/F411 working now.

@tzarc tzarc requested a review from a team April 28, 2020 16:51
@tzarc tzarc force-pushed the platforms-chibios-refactor branch from f92cf09 to 69a6ff6 Compare April 28, 2020 16:59
noroadsleft pushed a commit that referenced this pull request Jul 10, 2020
@tzarc @noroadsleft
Initial work for consolidation of ChibiOS platform files (#8327)
284d77b 
* Initial work for consolidation of board files and default ChibiOS configs.

* Migrate F401/F411 black pills for testing.

* Add early init bootloader jump flag.

* Add support for I2C in order to use i2c_scanner keymap.

* Add F401/F411 HSE bypass to get things booting.

* Exempt "hooked" ChibiOS conf files from updater script.

* Fix up ordering for bootloader_defs file check.

* Match previous $(KEYBOARD_PATHS) value for Proton-C, updated for all board configs.
noroadsleft pushed a commit that referenced this pull request Jul 18, 2020
@tzarc @noroadsleft
Initial work for consolidation of ChibiOS platform files (#8327)
16ffaf8 
* Initial work for consolidation of board files and default ChibiOS configs.

* Migrate F401/F411 black pills for testing.

* Add early init bootloader jump flag.

* Add support for I2C in order to use i2c_scanner keymap.

* Add F401/F411 HSE bypass to get things booting.

* Exempt "hooked" ChibiOS conf files from updater script.

* Fix up ordering for bootloader_defs file check.

* Match previous $(KEYBOARD_PATHS) value for Proton-C, updated for all board configs.
noroadsleft pushed a commit that referenced this pull request Jul 26, 2020
@tzarc @noroadsleft
Initial work for consolidation of ChibiOS platform files (#8327)
c83ea8c 
* Initial work for consolidation of board files and default ChibiOS configs.

* Migrate F401/F411 black pills for testing.

* Add early init bootloader jump flag.

* Add support for I2C in order to use i2c_scanner keymap.

* Add F401/F411 HSE bypass to get things booting.

* Exempt "hooked" ChibiOS conf files from updater script.

* Fix up ordering for bootloader_defs file check.

* Match previous $(KEYBOARD_PATHS) value for Proton-C, updated for all board configs.
noroadsleft pushed a commit that referenced this pull request Jul 31, 2020
@tzarc @noroadsleft
Initial work for consolidation of ChibiOS platform files (#8327)
49da1ed 
* Initial work for consolidation of board files and default ChibiOS configs.

* Migrate F401/F411 black pills for testing.

* Add early init bootloader jump flag.

* Add support for I2C in order to use i2c_scanner keymap.

* Add F401/F411 HSE bypass to get things booting.

* Exempt "hooked" ChibiOS conf files from updater script.

* Fix up ordering for bootloader_defs file check.

* Match previous $(KEYBOARD_PATHS) value for Proton-C, updated for all board configs.
noroadsleft pushed a commit that referenced this pull request Aug 11, 2020
@tzarc @noroadsleft
Initial work for consolidation of ChibiOS platform files (#8327)
faa0401 
* Initial work for consolidation of board files and default ChibiOS configs.

* Migrate F401/F411 black pills for testing.

* Add early init bootloader jump flag.

* Add support for I2C in order to use i2c_scanner keymap.

* Add F401/F411 HSE bypass to get things booting.

* Exempt "hooked" ChibiOS conf files from updater script.

* Fix up ordering for bootloader_defs file check.

* Match previous $(KEYBOARD_PATHS) value for Proton-C, updated for all board configs.
noroadsleft pushed a commit that referenced this pull request Aug 27, 2020
@tzarc @noroadsleft
Initial work for consolidation of ChibiOS platform files (#8327)
2642edf 
* Initial work for consolidation of board files and default ChibiOS configs.

* Migrate F401/F411 black pills for testing.

* Add early init bootloader jump flag.

* Add support for I2C in order to use i2c_scanner keymap.

* Add F401/F411 HSE bypass to get things booting.

* Exempt "hooked" ChibiOS conf files from updater script.

* Fix up ordering for bootloader_defs file check.

* Match previous $(KEYBOARD_PATHS) value for Proton-C, updated for all board configs.
noroadsleft pushed a commit that referenced this pull request Aug 29, 2020
@tzarc @noroadsleft
Initial work for consolidation of ChibiOS platform files (#8327)
385d49c 
* Initial work for consolidation of board files and default ChibiOS configs.

* Migrate F401/F411 black pills for testing.

* Add early init bootloader jump flag.

* Add support for I2C in order to use i2c_scanner keymap.

* Add F401/F411 HSE bypass to get things booting.

* Exempt "hooked" ChibiOS conf files from updater script.

* Fix up ordering for bootloader_defs file check.

* Match previous $(KEYBOARD_PATHS) value for Proton-C, updated for all board configs.
nicocesar pushed a commit to nicocesar/qmk_firmware that referenced this pull request Sep 6, 2020
@tzarc @nicocesar
Initial work for consolidation of ChibiOS platform files (qmk#8327)
7173f4d 
* Initial work for consolidation of board files and default ChibiOS configs.

* Migrate F401/F411 black pills for testing.

* Add early init bootloader jump flag.

* Add support for I2C in order to use i2c_scanner keymap.

* Add F401/F411 HSE bypass to get things booting.

* Exempt "hooked" ChibiOS conf files from updater script.

* Fix up ordering for bootloader_defs file check.

* Match previous $(KEYBOARD_PATHS) value for Proton-C, updated for all board configs.
drashna pushed a commit to zsa/qmk_firmware that referenced this pull request Sep 30, 2020
@tzarc @drashna
Initial work for consolidation of ChibiOS platform files (qmk#8327)
1dd7235 
* Initial work for consolidation of board files and default ChibiOS configs.

* Migrate F401/F411 black pills for testing.

* Add early init bootloader jump flag.

* Add support for I2C in order to use i2c_scanner keymap.

* Add F401/F411 HSE bypass to get things booting.

* Exempt "hooked" ChibiOS conf files from updater script.

* Fix up ordering for bootloader_defs file check.

* Match previous $(KEYBOARD_PATHS) value for Proton-C, updated for all board configs.
kjganz pushed a commit to kjganz/qmk_firmware that referenced this pull request Oct 28, 2020
@tzarc @noroadsleft
Initial work for consolidation of ChibiOS platform files (qmk#8327)
75b9612 
* Initial work for consolidation of board files and default ChibiOS configs.

* Migrate F401/F411 black pills for testing.

* Add early init bootloader jump flag.

* Add support for I2C in order to use i2c_scanner keymap.

* Add F401/F411 HSE bypass to get things booting.

* Exempt "hooked" ChibiOS conf files from updater script.

* Fix up ordering for bootloader_defs file check.

* Match previous $(KEYBOARD_PATHS) value for Proton-C, updated for all board configs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr left review comments

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

@skullydazed skullydazed Awaiting requested review from skullydazed

Assignees
No one assigned
Labels
core enhancement in progress keyboard optimization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tzarc @drashna @fauxpark @zvecr @noroadsleft