Bigger combo index #9318
Merged
Bigger combo index #9318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zvecr
added
breaking_change
|
Might need a rebase on top of latest |
sevanteri
force-pushed
the
bigger_combo_index
branch
from
0fa2e90
to
235b062
Compare
|
@tzarc Done. I also removed the commits that were part of my other PR so that this is smaller and mergable without the other PR. |
fauxpark
approved these changes
Jul 16, 2020
tzarc
approved these changes
Jul 16, 2020
13 tasks
noroadsleft
pushed a commit
that referenced
this pull request
Jul 18, 2020
* Add change log * Change combo index from uint8_t to uint16_t
noroadsleft
pushed a commit
that referenced
this pull request
Jul 26, 2020
* Add change log * Change combo index from uint8_t to uint16_t
noroadsleft
pushed a commit
that referenced
this pull request
Jul 31, 2020
* Add change log * Change combo index from uint8_t to uint16_t
noroadsleft
pushed a commit
that referenced
this pull request
Aug 11, 2020
* Add change log * Change combo index from uint8_t to uint16_t
noroadsleft
pushed a commit
that referenced
this pull request
Aug 27, 2020
* Add change log * Change combo index from uint8_t to uint16_t
noroadsleft
pushed a commit
that referenced
this pull request
Aug 29, 2020
* Add change log * Change combo index from uint8_t to uint16_t
nicocesar
pushed a commit
to nicocesar/qmk_firmware
that referenced
this pull request
Sep 6, 2020
* Add change log * Change combo index from uint8_t to uint16_t
drashna
pushed a commit
to zsa/qmk_firmware
that referenced
this pull request
Sep 30, 2020
* Add change log * Change combo index from uint8_t to uint16_t
kjganz
pushed a commit
to kjganz/qmk_firmware
that referenced
this pull request
Oct 28, 2020
* Add change log * Change combo index from uint8_t to uint16_t
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes
uint8_ttouin16_twhen looping over combos. With 16 bits we can have much more than 256 combos.Types of Changes
Issues Fixed or Closed by This PR
Checklist