Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add UNK keyboard. #9571

Merged
merged 5 commits into from
Jun 29, 2020
Merged

Add UNK keyboard. #9571

merged 5 commits into from
Jun 29, 2020

Conversation

herpiko
Copy link
Contributor

@herpiko herpiko commented Jun 28, 2020

Add UNK keyboard.

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

zvecr
zvecr requested changes Jun 28, 2020
View reviewed changes
Copy link
Member

@zvecr zvecr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also the project should be moved to keyboards/handwired/unk.

keyboards/unk/README.MD Outdated Show resolved Hide resolved
keyboards/unk/README.MD Outdated Show resolved Hide resolved
keyboards/unk/info.json Outdated Show resolved Hide resolved
keyboards/unk/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/unk/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/unk/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/unk/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/unk/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/unk/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/unk/keymaps/default/keymap.c Outdated Show resolved Hide resolved
@zvecr zvecr added the keyboard label Jun 28, 2020
@zvecr zvecr requested a review from a team June 28, 2020 14:24
fauxpark
fauxpark requested changes Jun 28, 2020
View reviewed changes
keyboards/unk/info.json Outdated Show resolved Hide resolved
@herpiko herpiko force-pushed the master branch 2 times, most recently from 85ad470 to e5454a6 Compare June 29, 2020 13:28
@herpiko
Copy link
Contributor Author

herpiko commented Jun 29, 2020

@zvecr @fauxpark Thank you.

I've made changes as requested and the tests have been passed too. Please review it again.

fauxpark
fauxpark requested changes Jun 29, 2020
View reviewed changes
keyboards/handwired/unk/rev1/rules.mk Outdated Show resolved Hide resolved
keyboards/handwired/unk/rules.mk Outdated Show resolved Hide resolved
fauxpark
fauxpark requested changes Jun 29, 2020
View reviewed changes
keyboards/handwired/unk/rev1/config.h Outdated Show resolved Hide resolved
keyboards/handwired/unk/rev1/rev1.h Show resolved Hide resolved
fauxpark
fauxpark requested changes Jun 29, 2020
View reviewed changes
keyboards/handwired/unk/info.json Outdated Show resolved Hide resolved
@herpiko
Copy link
Contributor Author

herpiko commented Jun 29, 2020 •
edited
Loading

@fauxpark I've tidied up the code, updated the PR, tested it with my keyboard and the checks has been passed. Could you check it again please?

@herpiko herpiko requested review from zvecr and fauxpark June 29, 2020 17:57
herpiko added a commit to herpiko/unk that referenced this pull request Jun 29, 2020
@herpiko
Update the firmware as requested by QMK maintainers (qmk/qmk_firmware…
7f967f5 
…#9571).
Erovia
Erovia approved these changes Jun 29, 2020
View reviewed changes
keyboards/handwired/unk/readme.md Outdated Show resolved Hide resolved
keyboards/handwired/unk/rev1/config.h Show resolved Hide resolved
keyboards/handwired/unk/keymaps/default/keymap.c Outdated Show resolved Hide resolved
herpiko and others added 2 commits June 30, 2020 02:02
@herpiko @Erovia
Update keyboards/handwired/unk/readme.md
1f2017d 
Co-authored-by: Erovia <Erovia@users.noreply.github.com>
@herpiko @Erovia
Update keyboards/handwired/unk/keymaps/default/keymap.c
e3b9f10 
Co-authored-by: Erovia <Erovia@users.noreply.github.com>
@noroadsleft noroadsleft merged commit 6d6340a into qmk:master Jun 29, 2020
@noroadsleft
Copy link
Member

For future reference, we recommend against committing to your master branch as you've done here, because pull requests from modified master branches can make it more difficult to keep your QMK fork updated. It is highly recommended for QMK development – regardless of what is being done or where – to keep your master updated, but NEVER commit to it. Instead, do all your changes in a branch (branches are basically free in Git) and issue PRs from your branches when you're developing.

There are instructions on how to keep your fork updated here:

Best Practices: Your Fork's Master: Update Often, Commit Never

Fixing Your Branch will walk you through fixing up your master branch moving forward. If you need any help with this just ask.

Thanks for contributing!

@herpiko
Copy link
Contributor Author

herpiko commented Jun 30, 2020

There are instructions on how to keep your fork updated here:

I've force-updated my master branch and move my own code to other branch. Thank you!

jakobaa pushed a commit to jakobaa/qmk_firmware that referenced this pull request Jul 7, 2020
@herpiko @jakobaa
[Keyboard] Add UNK keyboard. (qmk#9571)
4cb3a13 
* Add UNK keyboard.

* Update keyboards/handwired/unk/info.json

* Use KC_NO to block out nonexistent matrix positions.

* Update keyboards/handwired/unk/readme.md

* Update keyboards/handwired/unk/keymaps/default/keymap.c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Erovia Erovia Erovia approved these changes

@noroadsleft noroadsleft noroadsleft approved these changes

@zvecr zvecr Awaiting requested review from zvecr

@fauxpark fauxpark Awaiting requested review from fauxpark

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@herpiko @noroadsleft @Erovia @fauxpark @zvecr