Add BIOI Keyboards #9602

scottywei · 2020-06-30T18:05:24Z

Description

Add keyboards from BIOI, including dual-mode G60, Morgan65, and S65.

Types of Changes

Issues Fixed or Closed by This PR

Checklist

My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Add keyboards from BIOI, including dual-mode G60, Morgan65, and S65

fauxpark

So, I'm not really liking the BLE code here. I think we should hold off on this until I can refactor the Bluetooth support in QMK into something more manageable.

keyboards/bioi/g60/config.h

keyboards/bioi/g60/g60.c

keyboards/bioi/s65/s65.c

keyboards/bioi/s65/s65.h

keyboards/bioi/g60/info.json

keyboards/bioi/morgan65/info.json

keyboards/bioi/s65/info.json

Co-authored-by: Ryan <fauxpark@gmail.com>

scottywei · 2020-07-07T08:23:59Z

So, I'm not really liking the BLE code here. I think we should hold off on this until I can refactor the Bluetooth support in QMK into something more manageable.

Thank you so much for your work! I think maybe we can consider the BLE code here as the keyboard level custom functions. It almost the same way as the code for RN42 HHKB controller. I think I would help to bring the USB/Bluetooth switching code into the QMK core in the future.

nfp0 · 2020-08-04T11:04:39Z

Is there anything blocking this?

stale · 2020-09-19T12:20:03Z

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

scottywei · 2020-10-01T01:14:20Z

Any progress?

noroadsleft

Is there any difference between the G60 and the G60BLE?

scottywei · 2020-10-06T13:09:55Z

Is there any difference between the G60 and the G60BLE?

This is an official submission and as a duo-mode keyboard, this version contains the Bluetooth codes.

noroadsleft

Additionally:

All your new .c and .h files need to have license headers.
There are inconsistencies in the USB Device IDs. The already-in-QMK bioi/g60ble uses 0x6583 as the Vendor ID to avoid a collision with Wilba's boards, and 0x4249 is used by the binepad/bn003. Ideally all the BIOI boards should use the same Vendor ID to each other, and each should have a different Product ID.

keyboards/bioi/ble.h

keyboards/bioi/g60/config.h

keyboards/bioi/s65/info.json

keyboards/bioi/s65/readme.md

keyboards/bioi/s65/rules.mk

keyboards/bioi/s65/keymaps/default/keymap.c

stale · 2020-12-20T00:25:11Z

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

Change VenderID to 8101

scottywei · 2020-12-24T10:03:23Z

Change Vender ID for BIOI to 8101

keyboards/bioi/ble.h

keyboards/bioi/ble.c

keyboards/bioi/ble.h

keyboards/bioi/g60/keymaps/default/keymap.c

keyboards/bioi/g60/keymaps/via/keymap.c

Co-authored-by: Drashna Jaelre <drashna@live.com>

noroadsleft

I think this reads better, but everything else looks good to me.

keyboards/bioi/s65/readme.md

Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>

noroadsleft

Looks good to me.

nfp0 · 2021-01-11T09:49:28Z

Awesome!

Add BIOI Keyboards

e3cd21d

Add keyboards from BIOI, including dual-mode G60, Morgan65, and S65

scottywei mentioned this pull request Jul 2, 2020

Add BIOI keyboards #9552

Closed

13 tasks

zvecr requested review from fauxpark and a team July 3, 2020 21:32

zvecr added the keyboard label Jul 3, 2020

fauxpark requested changes Jul 4, 2020

View reviewed changes

scottywei and others added 8 commits July 7, 2020 15:54

Update keyboards/bioi/g60/config.h

3cb6017

Co-authored-by: Ryan <fauxpark@gmail.com>

Update keyboards/bioi/g60/config.h

ded07e0

Co-authored-by: Ryan <fauxpark@gmail.com>

Update keyboards/bioi/g60/g60.c

3f7cbd6

Co-authored-by: Ryan <fauxpark@gmail.com>

Update keyboards/bioi/g60/config.h

e107e34

Co-authored-by: Ryan <fauxpark@gmail.com>

Apply suggestions from code review

2c4e563

Co-authored-by: Ryan <fauxpark@gmail.com>

Rename rule.mk to rules.mk

59ff9b6

Rename rule.mk to rules.mk

b641601

Rename rule.mk to rules.mk

bb432ed

scottywei requested a review from fauxpark July 7, 2020 08:31

scottywei mentioned this pull request Jul 27, 2020

How is BT defined? scottywei/bioi-g60ble#3

Closed

noroadsleft requested a review from a team August 5, 2020 09:27

stale bot added the awaiting changes label Sep 19, 2020

noroadsleft reviewed Oct 1, 2020

View reviewed changes

stale bot removed the awaiting changes label Oct 1, 2020

noroadsleft requested changes Nov 4, 2020

View reviewed changes

stale bot added the awaiting changes label Dec 20, 2020

Update readme.md

2654267

stale bot removed the awaiting changes label Dec 24, 2020

scottywei added 6 commits December 24, 2020 17:48

Update ble.h

283df04

Update config.h

52ffb26

Change VenderID to 8101

Update config.h

a5df776

Update config.h

1b59bfa

Update ble.c

ccd6f6f

Update ble.h

77a0289

Add license headers

1b82d54

drashna requested changes Dec 24, 2020

View reviewed changes

scottywei and others added 2 commits December 25, 2020 09:59

Apply suggestions from code review

201fde9

Co-authored-by: Drashna Jaelre <drashna@live.com>

Add license header in keymap files

e838826

scottywei force-pushed the bioi-keyboards branch from 02be019 to e838826 Compare December 25, 2020 08:18

github-actions bot added keymap via Adds via keymap and/or updates keyboard for via support labels Dec 25, 2020

Fix year in license header

2d933b7

drashna approved these changes Dec 30, 2020

View reviewed changes

noroadsleft reviewed Jan 5, 2021

View reviewed changes

keyboards/bioi/s65/readme.md Outdated Show resolved Hide resolved

Update keyboards/bioi/s65/readme.md

c838d41

Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>

noroadsleft approved these changes Jan 9, 2021

View reviewed changes

drashna merged commit 6edbd84 into qmk:master Jan 11, 2021

scottywei mentioned this pull request Jan 16, 2021

Add G60, Morgan65 and S65 the-via/keyboards#67

Merged

7 tasks

andtari mentioned this pull request May 26, 2022

Bluetooth in QMK? scottywei/bioi-g60ble#17

Open

scottywei deleted the bioi-keyboards branch March 28, 2023 08:39

qmk deleted a comment from aymanbagabas Apr 9, 2023

qmk locked as off-topic and limited conversation to collaborators Apr 10, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add BIOI Keyboards #9602

Add BIOI Keyboards #9602

scottywei commented Jun 30, 2020

fauxpark left a comment

scottywei commented Jul 7, 2020 •

edited

Loading

nfp0 commented Aug 4, 2020

stale bot commented Sep 19, 2020

scottywei commented Oct 1, 2020

noroadsleft left a comment

scottywei commented Oct 6, 2020

noroadsleft left a comment

stale bot commented Dec 20, 2020

scottywei commented Dec 24, 2020

noroadsleft left a comment

noroadsleft left a comment

nfp0 commented Jan 11, 2021

Add BIOI Keyboards #9602

Add BIOI Keyboards #9602

Conversation

scottywei commented Jun 30, 2020

Description

Types of Changes

Issues Fixed or Closed by This PR

Checklist

fauxpark left a comment

Choose a reason for hiding this comment

scottywei commented Jul 7, 2020 • edited Loading

nfp0 commented Aug 4, 2020

stale bot commented Sep 19, 2020

scottywei commented Oct 1, 2020

noroadsleft left a comment

Choose a reason for hiding this comment

scottywei commented Oct 6, 2020

noroadsleft left a comment

Choose a reason for hiding this comment

stale bot commented Dec 20, 2020

scottywei commented Dec 24, 2020

noroadsleft left a comment

Choose a reason for hiding this comment

noroadsleft left a comment

Choose a reason for hiding this comment

nfp0 commented Jan 11, 2021

scottywei commented Jul 7, 2020 •

edited

Loading