Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Keyboard PH Arisu #9612

Merged
merged 52 commits into from
Jul 28, 2020
Merged

Add Keyboard PH Arisu #9612

merged 52 commits into from
Jul 28, 2020

Conversation

devinceble
Copy link
Contributor

@devinceble devinceble commented Jul 1, 2020 •
edited
Loading

Add new keyboard PH Arisu QMK support and VIA Compatibility

PH Arisu is base on https://github.com/FateNozomi/arisu-pcb but this used a Pro Micro
used for a local groupbuy in the philippines.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@devinceble devinceble mentioned this pull request Jul 1, 2020
Merged
6 tasks
@akscanb
Copy link
Contributor

akscanb commented Jul 1, 2020

Hey, dude I'm already in the process of trying to merge the arisu config into qmk. I also added via compatibility for it also.

@devinceble
Copy link
Contributor Author

Hey, dude I'm already in the process of trying to merge the arisu config into qmk. I also added via compatibility for it also.

Hey @akscanb this is different from the arisu though but we have same base project. That's why it PH Arisu not Arisu.

@drashna drashna requested a review from a team July 8, 2020 13:46
fauxpark
fauxpark requested changes Jul 8, 2020
View reviewed changes
keyboards/ph_arisu/config.h Outdated Show resolved Hide resolved
keyboards/ph_arisu/config.h Outdated Show resolved Hide resolved
keyboards/ph_arisu/config.h Outdated Show resolved Hide resolved
keyboards/ph_arisu/config.h Outdated Show resolved Hide resolved
keyboards/ph_arisu/config.h Outdated Show resolved Hide resolved
keyboards/ph_arisu/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/ph_arisu/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/ph_arisu/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/ph_arisu/rules.mk Outdated Show resolved Hide resolved
keyboards/ph_arisu/info.json Outdated Show resolved Hide resolved
@fauxpark fauxpark requested a review from a team July 8, 2020 16:07
@fauxpark fauxpark added keyboard via Adds via keymap and/or updates keyboard for via support labels Jul 8, 2020
devinceble and others added 15 commits July 9, 2020 14:13
@devinceble @fauxpark
Update keyboards/ph_arisu/config.h
aa3ce70 
Co-authored-by: Ryan <fauxpark@gmail.com>
@devinceble @fauxpark
Update keyboards/ph_arisu/config.h
3a8618b 
Co-authored-by: Ryan <fauxpark@gmail.com>
@devinceble @fauxpark
Update keyboards/ph_arisu/config.h
2b35aa1 
Co-authored-by: Ryan <fauxpark@gmail.com>
@devinceble @fauxpark
Update keyboards/ph_arisu/config.h
4a7e981 
Co-authored-by: Ryan <fauxpark@gmail.com>
@devinceble @fauxpark
Update keyboards/ph_arisu/keymaps/default/keymap.c
43d3194 
Co-authored-by: Ryan <fauxpark@gmail.com>
@devinceble @fauxpark
Update keyboards/ph_arisu/keymaps/default/keymap.c
7782fd7 
Co-authored-by: Ryan <fauxpark@gmail.com>
@devinceble @fauxpark
Update keyboards/ph_arisu/keymaps/via/keymap.c
a33285c 
Co-authored-by: Ryan <fauxpark@gmail.com>
@devinceble @fauxpark
Update keyboards/ph_arisu/rules.mk
79d35c5 
Co-authored-by: Ryan <fauxpark@gmail.com>
@devinceble
qmk#9612 (comment) Update info.json using converter
a38dea6
@devinceble
Fixed Clean endif
dac17c8
@devinceble
LAYOUT not defined Error on Compile fix
e35644a
@devinceble
Fix implicit declaration of function 'LAYOUT'
13a58f0
@devinceble
Update VIA keymap change KEYMAP to new LAYOUT method
6f67706
@devinceble
Merge branch 'master' of github.com:devinceble/qmk_firmware into devi…
039e4b9 
…nceble/arisu
@devinceble @fauxpark
Update keyboards/ph_arisu/config.h
8d70d6e 
Co-authored-by: Ryan <fauxpark@gmail.com>
devinceble and others added 3 commits July 22, 2020 11:29
@devinceble @noroadsleft
Update keyboards/ph_arisu/keymaps/via/keymap.c
180ab56 
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
@devinceble @noroadsleft
Update keyboards/ph_arisu/readme.md
7918f78 
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
@devinceble @noroadsleft
Update keyboards/ph_arisu/rules.mk
10e6b6e 
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
drashna
drashna approved these changes Jul 24, 2020
View reviewed changes
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devinceble @fauxpark
Update keyboards/nightly_boards/ph_arisu/rules.mk
a5ac827 
Co-authored-by: Ryan <fauxpark@gmail.com>
@noroadsleft noroadsleft merged commit bcfb70a into qmk:master Jul 28, 2020
@noroadsleft
Copy link
Member

Thanks!

Shinichi-Ohki added a commit to Shinichi-Ohki/qmk_firmware that referenced this pull request Jul 31, 2020
@Shinichi-Ohki
Merge branch 'master' of https://github.com/qmk/qmk_firmware
a932d60 
* 'master' of https://github.com/qmk/qmk_firmware: (156 commits)
  Add info.json for Jiran keyboard (qmk#9857)
  [Docs] Update Japanese translation of feature_ps2_mouse.md. (qmk#9815)
  [Docs] Update Japanese translation of feature_mouse_keys.md. (qmk#9809)
  [Keyboard] Add new keyboard ks63 handwired (qmk#9712)
  [keyboard] Add [n]2 support (qmk#9862)
  Timber Wolf - updated via keymap, reduced eeprom writing from backlight code (qmk#9876)
  [Docs] Update Japanese translation of feature_macros.md. (qmk#9767)
  [Keyboard] Add KPRepublic BM40HSRGB keyboard (qmk#9860)
  [Docs] Japanese translation of docs/internals_gpio_control.md (qmk#9751)
  [Docs] Japanese translation of docs/other_eclipse.md (qmk#9755)
  Added Via keymap to Spaceman 2% Milk (qmk#9484)
  Add via configuration for adelheid. (qmk#9830)
  Added Via-enabled keymap for Physix (qmk#9825)
  [Docs] Japanese translation of docs/one_shot_keys.md (qmk#9754)
  [Docs] Japanese translation of docs/mod_tap.md (qmk#9753)
  [Docs] Japanese translation of docs/how_keyboards_work.md (qmk#9683)
  [Docs] Japanese translation of docs/how_a_matrix_works.md (qmk#9682)
  [Keyboard] add bear_face/v2 (qmk#9642)
  [Keyboard] PH Arisu (qmk#9612)
  Timber Wolf - updated keymaps, fixed info.json (qmk#9787)
  ...
nicocesar pushed a commit to nicocesar/qmk_firmware that referenced this pull request Aug 12, 2020
@devinceble @nicocesar
[Keyboard] PH Arisu (qmk#9612)
1000638 
* Port Arisu to QMK

* Update Change name to PH Arisu

* Update PH Arisu for PR

* Update Bootloader

* Using Pro Micro

* Update Manufacturer Name

* Clean rules.mk

* Update keyboards/ph_arisu/config.h

* Update keyboards/ph_arisu/config.h

* Update keyboards/ph_arisu/config.h

* Update keyboards/ph_arisu/config.h

* Update keyboards/ph_arisu/keymaps/default/keymap.c

* Update keyboards/ph_arisu/keymaps/default/keymap.c

* Update keyboards/ph_arisu/keymaps/via/keymap.c

* Update keyboards/ph_arisu/rules.mk

* qmk#9612 (comment) Update info.json using converter

* Fixed Clean endif

* LAYOUT not defined Error on Compile fix

* Fix implicit declaration of function 'LAYOUT'

* Update VIA keymap change KEYMAP to new LAYOUT method

* Update keyboards/ph_arisu/config.h

* Update Remove RGB_DI_PIN

* Update keyboards/ph_arisu/config.h

* Update keyboards/ph_arisu/readme.md

* Update keyboards/ph_arisu/readme.md

* Update keyboards/ph_arisu/ph_arisu.h

* Update keyboards/ph_arisu/ph_arisu.h

* Update keyboards/ph_arisu/keymaps/via/keymap.c

* Update keyboards/ph_arisu/readme.md

* Update keyboards/ph_arisu/config.h

* Add MO(1) on Keymaps

* Update info.json for QMK configurator support

* Add PH Arisu Image

* Use Smaller Size Image for Keyboard

* Change Image Host to Imgur

* Fix Imgur url

* Fix Imgur url

* Update Change Keyboard Maintainer

* Update Change Hardware Support to Pro Micro ATmega32U4

* Update keyboards/ph_arisu/config.h

* Update keyboards/ph_arisu/ph_arisu.h

* Update keyboards/ph_arisu/keymaps/default/keymap.c

* Update keyboards/ph_arisu/keymaps/via/keymap.c

* Update keyboards/ph_arisu/readme.md

* Update keyboards/ph_arisu/rules.mk

* Update Move ph_arisu to nightly_boards directory

* Update Readme make command

* Update keyboards/nightly_boards/ph_arisu/rules.mk
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

@zvecr zvecr zvecr approved these changes

@noroadsleft noroadsleft noroadsleft approved these changes

@Erovia Erovia Awaiting requested review from Erovia

Assignees
No one assigned
Labels
keyboard via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@devinceble @akscanb @noroadsleft @drashna @Erovia @fauxpark @zvecr