[Keyboard] Add Arch-36 keyboard #9688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zvecr
requested changes
Jul 9, 2020
fauxpark
requested changes
Jul 10, 2020
Update based on PR Review comments Co-authored-by: Joel Challis <git@zvecr.com> Co-authored-by: Ryan <fauxpark@gmail.com>
Update to PR comments Co-authored-by: Joel Challis <git@zvecr.com> Co-authored-by: Ryan <fauxpark@gmail.com>
noroadsleft
requested changes
Jul 18, 2020
noroadsleft
approved these changes
Jul 28, 2020
|
Hey, seems like the linting is failing but it doesn't appear to be flagging anything from this PR. Any ideas what's going on there? |
|
The difference between your branch (specifically, the point in the Git history where it was forked from) and the current master branch includes changes to a keyboard that was failing but has since been fixed. The GitHub Action simply runs At some point this check will hopefully be improved so that it's a bit smarter and only looks at the changes in the PR. |
fauxpark
requested changes
Jul 31, 2020
Co-authored-by: Ryan <fauxpark@gmail.com>
fauxpark
approved these changes
Aug 5, 2020
|
Thanks! |
fdawans
pushed a commit
to fdawans/qmk_firmware
that referenced
this pull request
Aug 11, 2020
* Add Arch-36 keyboard * Apply suggestions from code review Update based on PR Review comments * Apply suggestions from code review Update to PR comments * Fix Build * Use full rules.mk template for Arch-36 keyboard * Reduce default firmware size * Update based on PR comments * Fix Copyright statement on arch_36:obosob keymap * Apply suggestions from code review
fdawans
added a commit
to fdawans/qmk_firmware
that referenced
this pull request
Aug 11, 2020
This reverts commit 9262a4b.
nicocesar
pushed a commit
to nicocesar/qmk_firmware
that referenced
this pull request
Aug 12, 2020
* Add Arch-36 keyboard * Apply suggestions from code review Update based on PR Review comments * Apply suggestions from code review Update to PR comments * Fix Build * Use full rules.mk template for Arch-36 keyboard * Reduce default firmware size * Update based on PR comments * Fix Copyright statement on arch_36:obosob keymap * Apply suggestions from code review
fcoury
pushed a commit
to fcoury/qmk_firmware_archive
that referenced
this pull request
Sep 20, 2020
* Add Arch-36 keyboard * Apply suggestions from code review Update based on PR Review comments * Apply suggestions from code review Update to PR comments * Fix Build * Use full rules.mk template for Arch-36 keyboard * Reduce default firmware size * Update based on PR comments * Fix Copyright statement on arch_36:obosob keymap * Apply suggestions from code review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Types of Changes
Issues Fixed or Closed by This PR
Checklist