Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Keyboard] Add via compatibility to Daisy 40 [1/2] #9805

Merged
merged 4 commits into from Aug 4, 2020
Merged

[Keyboard] Add via compatibility to Daisy 40 [1/2] #9805

merged 4 commits into from Aug 4, 2020

Conversation

jesdga95
Copy link
Contributor

@jesdga95 jesdga95 commented Jul 24, 2020 •
edited

Description

Adds compatibility for VIA on Daisy 40, for both split and full size spacebar

fullsize
split

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

VIA Pull Request

the-via/keyboards#226

Issues Fixed or Closed by This PR

  • N/A

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@jesdga95 jesdga95 changed the title [Keyboard] Add via compatibility to Daisy 40 [Keyboard] Add via compatibility to Daisy 40 [1/2] Jul 24, 2020
@jesdga95 jesdga95 mentioned this pull request Jul 24, 2020
Merged
6 tasks
zvecr
zvecr requested changes Jul 24, 2020
View reviewed changes
keyboards/daisy/config.h Outdated Show resolved Hide resolved
keyboards/daisy/rules.mk Outdated Show resolved Hide resolved
@zvecr zvecr added keyboard via Adds via keymap and/or updates keyboard for via support labels Jul 24, 2020
@jesdga95 jesdga95 requested a review from zvecr July 24, 2020 14:41
drashna
drashna requested changes Jul 31, 2020
View reviewed changes
Copy link
Member

@drashna drashna left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default layer count for VIA is 4, and as such you want to either set 4 layers, even if one is completely blank, or set the layer count to a lower value.

@jesdga95 jesdga95 requested a review from drashna August 3, 2020 20:50
@drashna drashna requested a review from a team August 4, 2020 03:34
@noroadsleft noroadsleft merged commit 7b85962 into qmk:master Aug 4, 2020
@noroadsleft
Copy link
Member

Thanks!

nicocesar pushed a commit to nicocesar/qmk_firmware that referenced this pull request Aug 12, 2020
@jesdga95 @nicocesar
Add via compatibility to Daisy 40 (qmk#9805)
384e6e9 
* Add via compatibility to Daisy 40

* Move via config to its own keymap

* Use lite bootmagic

* Add fourth layer to keymap
fcoury pushed a commit to fcoury/qmk_firmware_archive that referenced this pull request Sep 20, 2020
@jesdga95 @fcoury
Add via compatibility to Daisy 40 (qmk#9805)
6292e1a 
* Add via compatibility to Daisy 40

* Move via config to its own keymap

* Use lite bootmagic

* Add fourth layer to keymap
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@noroadsleft noroadsleft noroadsleft approved these changes

@zvecr zvecr Awaiting requested review from zvecr

Assignees
No one assigned
Labels
keyboard via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jesdga95 @noroadsleft @drashna @zvecr