Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Configurator data for Mechlovin Hannah910 rev2 #9903

Merged
merged 6 commits into from
Aug 5, 2020

Conversation

noroadsleft
Copy link
Member

Description

No layout data was provided for this keyboard:

image
LAYOUT_all shown; others similar

Also updated the layout macros to use K<row><column> notation, and made the layout macro names more Community Layout friendly, with aliases so they are backwards compatible.

cc @mechlovin (Keyboard Maintainer)

Types of Changes

  • Enhancement/optimization
  • Keyboard (addition or update)

Checklist

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

keyboards/mechlovin/hannah910/rev2/rules.mk Outdated Show resolved Hide resolved
keyboards/mechlovin/hannah910/rev2/rules.mk Outdated Show resolved Hide resolved
keyboards/mechlovin/hannah910/rev2/rules.mk Outdated Show resolved Hide resolved
@drashna drashna merged commit 3df5205 into qmk:master Aug 5, 2020
@noroadsleft noroadsleft deleted the cf/hannah910_rev2 branch August 6, 2020 19:10
fdawans pushed a commit to fdawans/qmk_firmware that referenced this pull request Aug 11, 2020
* fix Configurator data

* rework layout macros

* enable 65_ansi_blocker Community Layout support

* fix layout macro references in info.json

* update rules.mk per fauxpark

* update rules.mk per fauxpark II
fdawans added a commit to fdawans/qmk_firmware that referenced this pull request Aug 11, 2020
nicocesar pushed a commit to nicocesar/qmk_firmware that referenced this pull request Aug 12, 2020
* fix Configurator data

* rework layout macros

* enable 65_ansi_blocker Community Layout support

* fix layout macro references in info.json

* update rules.mk per fauxpark

* update rules.mk per fauxpark II
fcoury pushed a commit to fcoury/qmk_firmware_archive that referenced this pull request Sep 20, 2020
* fix Configurator data

* rework layout macros

* enable 65_ansi_blocker Community Layout support

* fix layout macro references in info.json

* update rules.mk per fauxpark

* update rules.mk per fauxpark II
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants