Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Kiibohd bootloader type to bootloader.mk #9908

Merged
merged 2 commits into from Aug 12, 2020
Merged

Add Kiibohd bootloader type to bootloader.mk #9908

merged 2 commits into from Aug 12, 2020

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented Aug 1, 2020

Description

A small tidyup for the I:C boards.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team August 1, 2020 17:18
noroadsleft
noroadsleft approved these changes Aug 2, 2020
View reviewed changes
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

__attribute__ ((weak)) ✔️

@noroadsleft noroadsleft requested a review from a team August 2, 2020 10:51
@fauxpark fauxpark merged commit e2d4cd1 into qmk:master Aug 12, 2020
@fauxpark fauxpark deleted the kiibohd-bootloader branch August 12, 2020 02:28
nicocesar pushed a commit to nicocesar/qmk_firmware that referenced this pull request Aug 12, 2020
@fauxpark @nicocesar
Add Kiibohd bootloader type to bootloader.mk (qmk#9908)
65b0594
@fauxpark fauxpark mentioned this pull request Aug 16, 2020
Merged
14 tasks
@andresilva andresilva mentioned this pull request Aug 21, 2020
Closed
3 tasks
tzarc added a commit to tzarc/qmk_firmware that referenced this pull request Aug 21, 2020
@tzarc
Revert "Add Kiibohd bootloader type to bootloader.mk (qmk#9908)"
b937203 
This reverts commit e2d4cd1.
@tzarc tzarc mentioned this pull request Aug 21, 2020
Merged
14 tasks
noroadsleft pushed a commit that referenced this pull request Aug 21, 2020
@tzarc
Revert "Add Kiibohd bootloader type to bootloader.mk (#9908)" (#10126)
70ce4ba 
This reverts commit e2d4cd1.
@fauxpark fauxpark mentioned this pull request Aug 22, 2020
Merged
14 tasks
nicocesar pushed a commit to nicocesar/qmk_firmware that referenced this pull request Sep 6, 2020
@tzarc @nicocesar
Revert "Add Kiibohd bootloader type to bootloader.mk (qmk#9908)" (qmk…
c0454d0 
…#10126)

This reverts commit e2d4cd1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarc tzarc tzarc approved these changes

@noroadsleft noroadsleft noroadsleft approved these changes

Assignees
No one assigned
Labels
enhancement keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fauxpark @tzarc @noroadsleft