Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] GitHub Actions build task succeeds even when compilation fails #5

Closed
andrebrait opened this issue Feb 6, 2024 · 3 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@andrebrait
Copy link

Describe the Bug

When running the GitHub Actions build flow, it succeeds even if it fails to compile and/or produce any artifacts.
I'm not sure whether that was intended.

Additional Context?

Example run: https://github.com/andrebrait/qmk_userspace/actions/runs/7771624531

@andrebrait andrebrait added the bug Something isn't working label Feb 6, 2024
@andrebrait
Copy link
Author

I guess this actually belongs in https://github.com/qmk/.github, correct?

@tzarc
Copy link
Member

tzarc commented Feb 8, 2024

I guess this actually belongs in qmk/.github, correct?

Eh, close enough here. Probably better visibility. Will have a look -- mine's failing too so at least I have a local repro.

@tzarc
Copy link
Member

tzarc commented May 15, 2024

Fixed.

@tzarc tzarc closed this as completed May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants