Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Actually add some tests #42

Closed
ChALkeR opened this issue Feb 18, 2016 · 5 comments
Closed

Actually add some tests #42

ChALkeR opened this issue Feb 18, 2016 · 5 comments
Labels
tests
Milestone
0.1.0

Comments

@ChALkeR
Copy link
Member

ChALkeR commented Feb 18, 2016

We need tests coverage to be sure that new patches aren't breaking existing things.
@ChALkeR ChALkeR added this to the 0.4.0 milestone Feb 18, 2016
@ChALkeR ChALkeR mentioned this issue Feb 18, 2016
Closed
@ChALkeR ChALkeR added the tests label Feb 18, 2016
@ChALkeR ChALkeR modified the milestones: 0.1.0, 0.4.0 Feb 19, 2016
@ChALkeR
Copy link
Member Author

ChALkeR commented Feb 19, 2016

Moving to 0.1.0 milestone, we actually need tests for checking that merges are not breaking things.

@henrikrudstrom
Copy link
Member

would like to contribute a bit to that,
having trouble with jasmine-phantom on windows though: see issue
hopefully that will be resolved soon.
Any thoughts on how to organize the tests?

@ChALkeR
Copy link
Member Author

ChALkeR commented Feb 19, 2016

@henrikrudstrom I'm going to make some examples soon, and those could be used as the starting point.

@ChALkeR
Copy link
Member Author

ChALkeR commented Feb 20, 2016

For starters, #50, #53, #54 should fix this.
Then we just need to add more tests =).

@ChALkeR
Copy link
Member Author

ChALkeR commented Feb 20, 2016

Fixed in #50, #53, #54.
Landed in 97d1ccb...39f12e5.

@ChALkeR ChALkeR closed this as completed Feb 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tests
Projects
None yet
Milestone
0.1.0
Development

No branches or pull requests
2 participants
@henrikrudstrom @ChALkeR