Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use karma, add Coveralls integration. #50

Merged
merged 3 commits into from
Feb 20, 2016
Merged

Use karma, add Coveralls integration. #50

merged 3 commits into from
Feb 20, 2016

Conversation

ChALkeR
Copy link
Member

@ChALkeR ChALkeR commented Feb 19, 2016

This gives us crude coverage analysis.
It's based on a single file atm (lib/qt.js), that has to be fixed later.
Another related problem is that it also analyzes the bundled uglify-js code.

There are several ways of fixing that, but that could be done in follow-up PRs.

This (sort of) fixes #40.

@ChALkeR
Copy link
Member Author

ChALkeR commented Feb 19, 2016

/cc @qmlweb/collaborators I want this reviewed.

It doesn't give us detailed analysis yet (that will follow), but it does give us an overall percentage.
Some more info is available in the coverage folder after running npm test locally.

ChALkeR added a commit that referenced this pull request Feb 19, 2016
@henrikrudstrom
Copy link
Member

That worked much better, had trouble getting gulp-jasmine-phantom to work, and it didnt seem so active.

@ChALkeR
Copy link
Member Author

ChALkeR commented Feb 19, 2016

@henrikrudstrom Should I treat this as a review? =)

@ChALkeR
Copy link
Member Author

ChALkeR commented Feb 20, 2016

Note that internally this still uses the same testing framework, Jasmine.

@ChALkeR ChALkeR mentioned this pull request Feb 20, 2016
@henrikrudstrom
Copy link
Member

if you want. Im no expert on testing, but this works out of the box and seems much more active, only thing i miss is the green text saying which tests passed...

@ChALkeR
Copy link
Member Author

ChALkeR commented Feb 20, 2016

No objections raised, merging.
This is just toolchain change and does not break (or touch) the actual code, so I'm confident in this.

@ChALkeR
Copy link
Member Author

ChALkeR commented Feb 20, 2016

@henrikrudstrom

only thing i miss is the green text saying which tests passed...

If it did that, then when there will be many tests, it would be noisy. It outputs only tests that fail =).

Also, this enables crude coverage analysis through istanbul.
It's based on a single file atm (lib/qt.js), that has to be fixed later.

PR-URL: #50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Code coverage analysis
2 participants