-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use karma, add Coveralls integration. #50
Conversation
/cc @qmlweb/collaborators I want this reviewed. It doesn't give us detailed analysis yet (that will follow), but it does give us an overall percentage. |
That worked much better, had trouble getting gulp-jasmine-phantom to work, and it didnt seem so active. |
@henrikrudstrom Should I treat this as a review? =) |
Note that internally this still uses the same testing framework, Jasmine. |
if you want. Im no expert on testing, but this works out of the box and seems much more active, only thing i miss is the green text saying which tests passed... |
No objections raised, merging. |
If it did that, then when there will be many tests, it would be noisy. It outputs only tests that fail =). |
Also, this enables crude coverage analysis through istanbul. It's based on a single file atm (lib/qt.js), that has to be fixed later. PR-URL: #50
This gives us crude coverage analysis.
It's based on a single file atm (
lib/qt.js
), that has to be fixed later.Another related problem is that it also analyzes the bundled
uglify-js
code.There are several ways of fixing that, but that could be done in follow-up PRs.
This (sort of) fixes #40.