Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@pavelvasev merge: Support importing code from GitHub #194

Closed
wants to merge 1 commit into from

Conversation

ChALkeR
Copy link
Member

@ChALkeR ChALkeR commented Apr 18, 2016

This merges cc54d05 and 8cea5b6.

Note: I have not reviewed this code yet, and I am not yet sure if we want it.

Ref: #32.

/cc @pavelvasev @Plaristote @akreuzkamp

@ChALkeR ChALkeR mentioned this pull request Apr 18, 2016
62 tasks
@Plaristote
Copy link
Member

It's my opinion, but I don't want this. Doesn't sound like something that we should provide ourselves in qmlweb.

@ChALkeR
Copy link
Member Author

ChALkeR commented Apr 19, 2016

I think that I also don't like this in the current state.

Perhaps we could replace this with some abstract solution that would support user-supplied (or provided in a separate file) path preprocessors for those two methods?

@Plaristote
Copy link
Member

Sounds like the way to go.

We're most likely going to rewrite the better part of the import code anyhow. Perhaps we should just add this to the todo-list for this task (I see we haven't opened an issue on it... but I'm pretty sure I read some of us talking about the import rewrite, we should probably gather what was said there and open an issue... I'll try to find it).

@ChALkeR
Copy link
Member Author

ChALkeR commented Apr 20, 2016

@Plaristote I opened #203 for a replacement of this.

@ChALkeR ChALkeR closed this Apr 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants