@pavelvasev merge: Aliases now emit changes signals #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChALkeR
force-pushed
the
merge-paverlvasev-aliassignals
branch
from
1e3057b
to
9b4f0f3
Compare
|
Updated, a second aliases-related commit added, a second testcase is now fixed by this changeset 😉. |
ChALkeR
force-pushed
the
merge-paverlvasev-aliassignals
branch
from
9b4f0f3
to
c31ec78
Compare
| targetProp.changed.apply( obj, arguments ); | ||
| loopWatchdog = false; | ||
| } ); | ||
| } ) (); |
There was a problem hiding this comment.
Note: code style is not perfect here, e.g. ( function() { wrap is not needed. But we can fix that later at the cleanup stage, I would want to keep it like this until we complete the merges.
|
This does LGTM, the change here is additive. |
ChALkeR
force-pushed
the
merge-paverlvasev-aliassignals
branch
from
c31ec78
to
b0df2f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merges 780450b and the aliases part of dce7d96.
Note: I have not reviewed this code.
Note: This fixes two testcases. It also blocks sorting out the two remaining changestets of #32, so it would be better to review this quickly =).
Ref: #32.
/cc @pavelvasev @Plaristote @akreuzkamp