Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TextInput: fallback to password for NoEcho, PasswordEchoOnEdit #47

Merged
merged 1 commit into from
Feb 27, 2016
Merged

TextInput: fallback to password for NoEcho, PasswordEchoOnEdit #47

merged 1 commit into from
Feb 27, 2016

Conversation

ChALkeR
Copy link
Member

@ChALkeR ChALkeR commented Feb 19, 2016

This is done instead of merging 8c6ec04, because most part of that is already implemented in a different way.

@ChALkeR ChALkeR mentioned this pull request Feb 19, 2016
Closed
27 tasks
@Plaristote
Copy link
Member

Looks good to me
Edit: wait, actually, I believe the third parameter for createSimpleProperty isn't the default value, but whether the property is read/write or read only.
After checking, it is indeed. Which is curious, because the description over the function speaks of an "options" parameter that isn't implemented, but is supposed to allow fine-tuning of the property. Maybe we should implement access and default value by making this options parameter a reality ?

@henrikrudstrom
Copy link
Member

LGTM
@Plaristote im open for options or adding a 5th parameter, but that should be a separate PR

@akreuzkamp
Copy link
Member

lgtm

@Plaristote
Copy link
Member

LGTM.
PR #78 can make the options a reality if we all agree that's how createSimpleProperty should behave.

@ChALkeR
Copy link
Member Author

ChALkeR commented Feb 27, 2016

@Plaristote I don't see anything in this PR that uses the default parameter.

@ChALkeR
Copy link
Member Author

ChALkeR commented Feb 27, 2016

@Plaristote Ah, actually that was in the initial commit by @akreuzkamp. I see. Missed that, thanks for noticing!

@ChALkeR
TextInput: fallback to password for NoEcho, PasswordEchoOnEdit
62df41d 
PR-URL: #47
Reviewed-By: Michael Martin Moro <michael@unetresgrossebite.com>
Reviewed-By: Henrik Rudstrøm <hrudstrom@gmail.com>
Reviewed-By: Anton Kreuzkamp <akreuzkamp@web.de>
@ChALkeR ChALkeR merged commit 62df41d into master Feb 27, 2016
@ChALkeR ChALkeR deleted the textinput-echoMode branch April 5, 2016 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ChALkeR @Plaristote @henrikrudstrom @akreuzkamp