Merge pavel repeater #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hard to say, but its only related to repeater, so its shouldnt be able to cause that much trouble worst case. LGTM |
ChALkeR
force-pushed
the
merge-pavel-repeater
branch
from
1f51d08
to
6bc49db
Compare
If model is integer, Repeater failed. This is due it started to create children earlier than it's parent property is set. When repeater model is Int, it cleared all items on model change. Now we clear only if necessary. PR-URL: #96 Reviewed-By: Henrik Rudstrøm <hrudstrom@gmail.com>
PR-URL: #96 Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
ChALkeR
force-pushed
the
merge-pavel-repeater
branch
from
6bc49db
to
2413330
Compare
|
Squashed, merging. Tests change LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the RepeaterNumber failing test.
Any comments on the TODO in the last commit?