Fixed integer overflow issue causing windows cross compile to fail #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qmuntal
requested changes
Jul 20, 2020
decoder.go
Outdated
| @@ -47,7 +48,7 @@ func Open(name string) (*Document, error) { | |||
| type Decoder struct { | |||
| ReadHandler ReadHandler | |||
| MaxExternalBufferCount int | |||
| MaxMemoryAllocation int | |||
| MaxMemoryAllocation uint32 | |||
There was a problem hiding this comment.
I would rather use uint64 to support more than 4Gb quotas.
|
Hi, Thanks |
qmuntal
approved these changes
Jul 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Great library.
I saw that windows cross compiling was failing due to the 4GB constant overflowing the signed integer. So I changed it to use uint32 and the math package's maxUint32.
Thanks,
Jacob