Fix race conditions in queued Fire #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: qmuntal <quimmuntal@gmail.com> Co-authored-by: liang-kang <kang_liang@qq.com>
Closed
there exists a tiny gap between finishing iterations of firing queued event and sm.op decrease If another routine run internalFireQueued in that gap, it will not firing but save trigger in eventqueue and return Meanwhile, origin routine will not check event queue again because interations has finished so such trigger event will be left in queue and wait for later firing trigger to executing. if no trigger again, this trigger event will wait for ever.
|
This PR may break the rule of run-to-complete. Try to fix it with #69 |
fix potential issue of statemachine trigger lost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reimplements how triggers are fired in queued mode to make it more robust to race conditions.
It contains learnings from #66, which supersedes.