Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing access flags to be set on classes #6

Merged
merged 2 commits into from Sep 10, 2013
Merged

Allowing access flags to be set on classes #6

merged 2 commits into from Sep 10, 2013

Conversation

ghost
Copy link

@ghost ghost commented Sep 8, 2013

Change to allow access flags to be set on classes with a default of ACC_PUBLIC. The ACC_SUPER access flag is always set.

Other changes:

  • Adding child classes
  • Default constructor visibility
  • Some tests around class/constructor visibility

@qmx
Copy link
Owner

qmx commented Sep 9, 2013

this looks good, I'm just wondering whether should we add some tests for this, and how to test it...

@ghost
Copy link
Author

ghost commented Sep 9, 2013

Lemme whip something together in the morning. I would imagine building a class with a non-public bit in a different package might do the trick with a check against isAccessible(), right?

Logan McGrath
Sent from my iPwn

On Sep 8, 2013, at 10:31 PM, Douglas Campos notifications@github.com wrote:

this looks good, I'm just wondering whether should we add some tests for this, and how to test it...


Reply to this email directly or view it on GitHub.

@qmx qmx merged commit 2401d99 into qmx:master Sep 10, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant