Skip to content

Commit

Permalink
Put a service on into a top hierarchy of each cgroup
Browse files Browse the repository at this point in the history
This change will fix unwanted cgroup inheriting from user cgroups,
and fixes issues with systemd cgroup tracking by logind.

However this fix can lead to incorrect work for some user cgroup
controllers - so more advanced solution, that coveres such cases
will be created later.
  • Loading branch information
qnikst committed Jun 30, 2013
1 parent ccb8c58 commit 7ed2c61
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions sh/rc-cgroup.sh.in
Expand Up @@ -72,6 +72,10 @@ cgroup_set_values()

cgroup_set_limits()
{
for d in /sys/fs/cgroup/* ; do
echo $$ > /sys/fs/cgroup/"${d}"/tasks

This comment has been minimized.

Copy link
@lxnay

lxnay Jun 30, 2013

It should be: echo $$ > "${d}"/tasks

I get this otherwise:
sabayon ~ # /etc/init.d/system-tools-backends restart
/lib64/rc/sh/rc-cgroup.sh: line 76: /sys/fs/cgroup//sys/fs/cgroup/bfqio/tasks: No such file or directory
/lib64/rc/sh/rc-cgroup.sh: line 76: /sys/fs/cgroup//sys/fs/cgroup/blkio/tasks: No such file or directory
/lib64/rc/sh/rc-cgroup.sh: line 76: /sys/fs/cgroup//sys/fs/cgroup/cpu/tasks: No such file or directory
/lib64/rc/sh/rc-cgroup.sh: line 76: /sys/fs/cgroup//sys/fs/cgroup/cpuacct/tasks: No such file or directory
/lib64/rc/sh/rc-cgroup.sh: line 76: /sys/fs/cgroup//sys/fs/cgroup/cpuset/tasks: No such file or directory
/lib64/rc/sh/rc-cgroup.sh: line 76: /sys/fs/cgroup//sys/fs/cgroup/debug/tasks: No such file or directory
/lib64/rc/sh/rc-cgroup.sh: line 76: /sys/fs/cgroup//sys/fs/cgroup/devices/tasks: No such file or directory
/lib64/rc/sh/rc-cgroup.sh: line 76: /sys/fs/cgroup//sys/fs/cgroup/freezer/tasks: No such file or directory
/lib64/rc/sh/rc-cgroup.sh: line 76: /sys/fs/cgroup//sys/fs/cgroup/openrc/tasks: No such file or directory
/lib64/rc/sh/rc-cgroup.sh: line 76: /sys/fs/cgroup//sys/fs/cgroup/perf_event/tasks: No such file or directory
/lib64/rc/sh/rc-cgroup.sh: line 76: /sys/fs/cgroup//sys/fs/cgroup/systemd/tasks: No such file or directory

  • Stopping system-tools-backend ... [ ok ]
    /lib64/rc/sh/rc-cgroup.sh: line 76: /sys/fs/cgroup//sys/fs/cgroup/bfqio/tasks: No such file or directory
    /lib64/rc/sh/rc-cgroup.sh: line 76: /sys/fs/cgroup//sys/fs/cgroup/blkio/tasks: No such file or directory
    /lib64/rc/sh/rc-cgroup.sh: line 76: /sys/fs/cgroup//sys/fs/cgroup/cpu/tasks: No such file or directory
    /lib64/rc/sh/rc-cgroup.sh: line 76: /sys/fs/cgroup//sys/fs/cgroup/cpuacct/tasks: No such file or directory
    /lib64/rc/sh/rc-cgroup.sh: line 76: /sys/fs/cgroup//sys/fs/cgroup/cpuset/tasks: No such file or directory
    /lib64/rc/sh/rc-cgroup.sh: line 76: /sys/fs/cgroup//sys/fs/cgroup/debug/tasks: No such file or directory
    /lib64/rc/sh/rc-cgroup.sh: line 76: /sys/fs/cgroup//sys/fs/cgroup/devices/tasks: No such file or directory
    /lib64/rc/sh/rc-cgroup.sh: line 76: /sys/fs/cgroup//sys/fs/cgroup/freezer/tasks: No such file or directory
    /lib64/rc/sh/rc-cgroup.sh: line 76: /sys/fs/cgroup//sys/fs/cgroup/openrc/tasks: No such file or directory
    /lib64/rc/sh/rc-cgroup.sh: line 76: /sys/fs/cgroup//sys/fs/cgroup/perf_event/tasks: No such file or directory
    /lib64/rc/sh/rc-cgroup.sh: line 76: /sys/fs/cgroup//sys/fs/cgroup/systemd/tasks: No such file or directory
  • Starting system-tools-backend ... [ ok ]
    sabayon ~ #
done

openrc_cgroup=/sys/fs/cgroup/openrc
if [ -d "$openrc_cgroup" ]; then
cgroup="$openrc_cgroup/$RC_SVCNAME"
Expand Down

0 comments on commit 7ed2c61

Please sign in to comment.