Add in-place option to shift transform #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chilland
approved these changes
Aug 25, 2017
transform/shift.go
Outdated
| @@ -8,8 +8,13 @@ import ( | |||
| ) | |||
|
|
|||
| // Shift moves values from one provided json path to another in raw []byte. | |||
| func Shift(spec *Config, data []byte) ([]byte, error) { | |||
| outData := []byte(`{}`) | |||
| func Shift(spec *InPlaceConfig, data []byte) ([]byte, error) { | |||
There was a problem hiding this comment.
InPlaceConfig is not a defined struct. This should still be *Config
|
It's really helpful to hit `:wq` BEFORE committing...
…--
*Ryan Leary*
Chief Technology Officer
Qntfy <https://qntfy.com> | 1100 Wilson Blvd, Arlington, VA 30189
On Fri, Aug 25, 2017 at 9:49 AM, Casey Hilland ***@***.***> wrote:
***@***.**** approved this pull request.
------------------------------
In transform/shift.go
<#52 (comment)>:
> @@ -8,8 +8,13 @@ import (
)
// Shift moves values from one provided json path to another in raw []byte.
-func Shift(spec *Config, data []byte) ([]byte, error) {
- outData := []byte(`{}`)
+func Shift(spec *InPlaceConfig, data []byte) ([]byte, error) {
InPlaceConfig is not a defined struct. This should still be *Config
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#52 (review)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ACHC6Nd7weuN-Vhciwuf418CPuj4ULUsks5sbtDvgaJpZM4PCNCF>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a top-level
in-placefield to spec definitions that can be supported by other transforms in the future.