Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update things to work with MTK v9 #197

Merged
merged 8 commits into from
Apr 3, 2024
Merged

Conversation

david-pl
Copy link
Member

@david-pl david-pl commented Mar 8, 2024

No description provided.

@david-pl david-pl marked this pull request as ready for review March 20, 2024 20:09
Copy link

codecov bot commented Mar 20, 2024

Codecov Report

Attention: Patch coverage is 93.33333% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 80.11%. Comparing base (05d8536) to head (64bf479).
Report is 2 commits behind head on master.

Files Patch % Lines
src/qnumber.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #197      +/-   ##
==========================================
+ Coverage   79.01%   80.11%   +1.09%     
==========================================
  Files          26       26              
  Lines        5271     5572     +301     
==========================================
+ Hits         4165     4464     +299     
- Misses       1106     1108       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@david-pl david-pl mentioned this pull request Mar 20, 2024
@david-pl
Copy link
Member Author

david-pl commented Apr 1, 2024

@ChristophHotter as discussed, could you please fix the hangs on the steady state computation in the examples in the docs? I think this should be good to go then.

@ChristophHotter
Copy link
Member

@david-pl I think the steady-state computation is fine. The problem was the function remake(), the kwarg p changed there. The docu now takes ~30min to build.

@ChristophHotter ChristophHotter merged commit ab0d426 into master Apr 3, 2024
5 checks passed
@ChristophHotter ChristophHotter deleted the update-to-mtk-9 branch April 3, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants