Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix issue where 0 would not trigger an update call on blur #418

Merged
merged 2 commits into from
Mar 7, 2023
Merged

fix issue where 0 would not trigger an update call on blur #418

merged 2 commits into from
Mar 7, 2023

Conversation

poulet42
Copy link
Contributor

@poulet42 poulet42 commented Feb 6, 2023

Description

This MR fixes an issue I introduced in #410 where falsy numbers (0; 0.00 etc) would not trigger the extra update call with a formatted value. 馃檱馃従

Changes

  • Add failing test should call update with the formatted value on blur if the value is 0
  • Fix the condition used to call this.args.update in the onFocusOut handler.

@poulet42 poulet42 added the bug Something isn't working label Feb 6, 2023
@poulet42 poulet42 self-assigned this Feb 6, 2023
@poulet42 poulet42 merged commit 1dc8947 into qonto:master Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrloop mrloop mrloop approved these changes

@CYriuk CYriuk CYriuk approved these changes

Assignees

@poulet42 poulet42

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@poulet42 @mrloop @CYriuk