Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: remove double pnpm install on CI #492

Merged
merged 1 commit into from
Jun 5, 2023
Merged

ci: remove double pnpm install on CI #492

merged 1 commit into from
Jun 5, 2023

Conversation

poulet42
Copy link
Contributor

@poulet42 poulet42 commented Jun 5, 2023

This MR removes the double pnpm install: NullVoxPopuli/action-setup-pnpm already calls pnpm install and expose an args input

@poulet42 poulet42 requested a review from vscav June 5, 2023 12:05
@vscav
Copy link
Member

vscav commented Jun 5, 2023

This pnpm setup action definitely does a lot. Thanks for spotting this @poulet42 🙏

@vscav
Copy link
Member

vscav commented Jun 5, 2023

We can probably also consider removing the pnpm install command from the release.yml script. WDYT?

@poulet42
Copy link
Contributor Author

poulet42 commented Jun 5, 2023

We can probably also consider removing the pnpm install command from the release.yml script. WDYT?

Oops you're right, added it :)

@poulet42 poulet42 merged commit b9dd1f3 into qonto:master Jun 5, 2023
10 checks passed
@vscav vscav added the internal label Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vscav vscav vscav approved these changes

Assignees
No one assigned
Labels
internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@poulet42 @vscav