Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add TypeScript configuration #543

Merged
merged 10 commits into from
Sep 22, 2023
Merged

feat: add TypeScript configuration #543

merged 10 commits into from
Sep 22, 2023

Conversation

vscav
Copy link
Member

@vscav vscav commented Sep 8, 2023

In this MR, we setup everything needed to convert the amount-input component to TypeScript.

It can be reviewed commit by commit.

@vscav vscav self-assigned this Sep 8, 2023
@vscav vscav added the internal label Sep 8, 2023
@vscav vscav changed the title Setup TypeScript Add TypeScript configuration Sep 8, 2023
@vscav vscav force-pushed the typescript-setup branch 3 times, most recently from 1eec010 to 2f8954e Compare September 19, 2023 07:22
@vscav vscav marked this pull request as ready for review September 19, 2023 16:13
ember-amount-input/.eslintrc.cjs Outdated Show resolved Hide resolved
test-app/.eslintrc.js Outdated Show resolved Hide resolved
ember-amount-input/package.json Show resolved Hide resolved
Copy link
Collaborator

@dannycalleri dannycalleri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job @vscav 👏

@vscav vscav merged commit 35dd8c4 into master Sep 22, 2023
10 checks passed
@vscav vscav deleted the typescript-setup branch September 22, 2023 09:55
@vscav vscav changed the title Add TypeScript configuration feat: add TypeScript configuration Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants