fix(typing): positional argument should extends Array<any>

qonto · Jan 15, 2024 · 47b8b9b · 47b8b9b
1 parent 9a6a191
commit 47b8b9b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/ember-autofocus-modifier/src/modifiers/autofocus.ts b/ember-autofocus-modifier/src/modifiers/autofocus.ts
@@ -16,7 +16,7 @@ const DEFAULT_SELECTOR =
 interface ModifierArgs {
   Element: HTMLElement;
   Args: {
-    Positional: [string?] | undefined; // Optional selector
+    Positional: [string?]; // Optional selector
     Named: {
       disabled?: boolean; // Optional 'disabled' parameter
     };

diff --git a/test-app/tests/integration/modifiers/autofocus-test.ts b/test-app/tests/integration/modifiers/autofocus-test.ts
@@ -181,7 +181,7 @@ module('Integration | Modifier | autofocus', function (hooks) {
 
   test('should not focus due to disabled parameter set to true without providing a selector', async function (assert) {
     await render(hbs`
-      <div {{autofocus disabled=true}}>
+      <div {{autofocus "input" disabled=true}}>
         <span>this is not a focusable element</span>
         <button type="button" data-test-button>this is a button</button>
         <input id="1" data-test-input-1 />
@@ -206,7 +206,7 @@ module('Integration | Modifier | autofocus', function (hooks) {
 
   test('should focus due to disabled parameter set to false', async function (assert) {
     await render(hbs`
-      <div {{autofocus disabled=false}}>
+      <div {{autofocus "input" disabled=false}}>
         <span>this is not a focusable element</span>
         <button type="button" data-test-button>this is a button</button>
         <input id="1" data-test-input-1 />