Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(peer-deps): remove ember-source v5 from peerDependencies #435

Merged
merged 1 commit into from
Sep 28, 2023
Merged

fix(peer-deps): remove ember-source v5 from peerDependencies #435

merged 1 commit into from
Sep 28, 2023

Conversation

dannycalleri
Copy link
Collaborator

@dannycalleri dannycalleri commented Sep 28, 2023 •
edited

Removing ember-source@5 from peerDepencies since we had multiple problems with it in the following PRs:

@dannycalleri dannycalleri marked this pull request as ready for review September 28, 2023 14:49
@dannycalleri dannycalleri merged commit 3abb435 into master Sep 28, 2023
9 checks passed
@dannycalleri dannycalleri deleted the remove-support-ember5 branch September 28, 2023 15:01
@dannycalleri dannycalleri added the bug Something isn't working label Oct 4, 2023
@vscav vscav changed the title chore: remove ember-source v5 from peerDependencies fix(peer-deps): remove ember-source v5 from peerDependencies Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vscav vscav vscav approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dannycalleri @vscav