refactor: migrate addon to TypeScript

[dannycalleri]

This PR migrates the addon code to TypeScript.

This safely removes the {eager: false} option introduced in ea239a3 to prepare for ember-modifier@4 migration: https://github.com/ember-modifier/ember-modifier/blob/main/MIGRATIONS.md#when-is-this-a-breaking-change

Now that we're using v4, we can safely remove it since it's the default behavior. Also, ember-modifier types do not support that parameter anymore.

[vscav]

Thanks @dannycalleri 🙏 I have one question/comment: I think we are missing the exportation of the types through the Registry. Without it, we couldn't access the type info when using the addon in a consuming app. Is it on purpose? Do you plan to do it in a separate PR?

[dannycalleri]

Thanks @dannycalleri 🙏 I have one question/comment: I think we are missing the exportation of the types through the Registry. Without it, we couldn't access the type info when using the addon in a consuming app. Is it on purpose? Do you plan to do it in a separate PR?

I thought that each dependant could add it on its own, with an example to be added on the test app PR. But I like the approach we followed here: https://github.com/qonto/ember-amount-input/blob/cff4ba9306b553ce7ac66cbb549c3a4498c0ac84/ember-amount-input/src/template-registry.ts

I added the same!

[vscav]

With @m-jovan, we discussed introducing some jobs to lint the addon with different TypeScript versions. This way, we can offer a reliable TypeScript compatibility information. Here is an example in ember-amount-input. What do you think about this? Do you think we should consider adding the same here?

[dannycalleri]

With @m-jovan, we discussed introducing some jobs to lint the addon with different TypeScript versions. This way, we can offer a reliable TypeScript compatibility information. Here is an example in ember-amount-input. What do you think about this? Do you think we should consider adding the same here?

I think it's a very good idea! 👍

Right now I see that we're specifying the working dir as working-directory: ember-amount-input (https://github.com/qonto/ember-amount-input/pull/589/files#diff-b803fcb7f17ed9235f1e5cb1fcd2f5d3b2838429d4368ae4c57ce4436577f03fR110).

I think that it would be beneficial to lint also the test-app, so that we keep the repo aligned. What do you think?

EDIT: this eventual change for the test-app will be done in #436

[vscav]

I think that it would be beneficial to lint also the test-app, so that we keep the repo aligned. What do you think?

Yes, good idea 👍 In that case we'd need to introduce the same command (lint:types) in the PR for the migration of the test-app

[vscav]

Just thought about this: I'd suggest to update the allowJs option to an explicit false in the tsconfig, wdyt?

[vscav]

🚀