Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ts-lint): allow use of private and protected syntax for classes in .ts files #458

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

vscav
Copy link
Member

@vscav vscav commented Oct 20, 2023

In this PR, we update the rules in our TS eslint config to allow the use of the private and protected keywords in TypeScript classes definition.

@vscav vscav changed the title feat(lint): allow use of classic private syntax feat(ts-lint): allow use of private and protected syntax for classes in .ts files Oct 20, 2023
@vscav vscav self-assigned this Oct 20, 2023
@vscav vscav added the internal label Oct 20, 2023
@vscav vscav marked this pull request as ready for review October 20, 2023 12:58
Copy link
Collaborator

@dannycalleri dannycalleri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

@vscav vscav merged commit 0d69a08 into master Oct 20, 2023
14 checks passed
@vscav vscav deleted the allow-private-members branch October 20, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants