Bump ember-validators from 3.0.1 to 4.0.0 #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
herzzanu
changed the title
|
It looks like we also need to update the node version
|
herzzanu
force-pushed
the
bumb-ember-validators-to-4.0.0
branch
from
7e11d4b
to
5938e6c
Compare
|
It seems ember-validators 4.0.0 dropped support for moment as well as made a few other updates that are breaking the tests here adopted-ember-addons/ember-validators#100 |
herzzanu
force-pushed
the
bumb-ember-validators-to-4.0.0
branch
from
538a3fc
to
28a66a7
Compare
herzzanu
force-pushed
the
bumb-ember-validators-to-4.0.0
branch
from
60513d2
to
8a771b9
Compare
enna
reviewed
Dec 31, 2021
enna
approved these changes
Dec 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order for apps using this addon to be upgraded to Ember 4.0, we need to make sure all subdependencies use ember-cli-babel 7.x.
ember-validators3.x version is using ember-cli-babel 6.x but the latest version uses ember-cli-babel 7.x.