Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary jobs in CI script #132

Merged
merged 3 commits into from
Jun 20, 2023
Merged

Remove unnecessary jobs in CI script #132

merged 3 commits into from
Jun 20, 2023

Conversation

vscav
Copy link
Member

@vscav vscav commented Jun 2, 2023

In this MR, we make some updates to our CI script, because we now use NullVoxPopuli/action-setup-pnpm and it already:

  • handles the node setup (so we were running actions/setup-node twice)
  • calls pnpm install and expose an args input (so we were running pnpm install command twice)

We had to add some @babel plugins to avoid getting unresolved module errors during the setup.

@vscav vscav self-assigned this Jun 2, 2023
@vscav vscav added the internal label Jun 2, 2023
@vscav vscav changed the title Update CI action Remove double node installation on CI Jun 5, 2023
@vscav vscav force-pushed the update-ci-action branch 3 times, most recently from e893390 to caea48b Compare June 5, 2023 10:31
@vscav vscav changed the title Remove double node installation on CI Remove unnecessary jobs in CI script Jun 5, 2023
@vscav vscav force-pushed the update-ci-action branch 2 times, most recently from 8048503 to 625a7be Compare June 5, 2023 13:56
@vscav vscav marked this pull request as ready for review June 5, 2023 14:02
Copy link
Member

@mrloop mrloop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mrloop mrloop merged commit 6975365 into main Jun 20, 2023
10 checks passed
@dbendaou dbendaou deleted the update-ci-action branch December 27, 2023 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants