Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lottie.ts): passing credentials include param to fetch request #274

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

mrloop
Copy link
Member

@mrloop mrloop commented Nov 10, 2023

Rebased and cleaned up from #131

Fetch request is failing with 403 when trying to fetch lottie json hosted on another domain that gates the assests behind credentials. https://javascript.info/fetch-crossorigin#credentials

@mrloop mrloop marked this pull request as draft November 10, 2023 08:51
…request

Fetch request is failing with 403 when trying to fetch lottie json hosted on another domain that gates the assests behind credentials.
https://javascript.info/fetch-crossorigin#credentials
@mrloop mrloop force-pushed the update-fetch-to-include-credentials branch from b41aa9a to 2eb326b Compare November 10, 2023 09:07
@mrloop mrloop marked this pull request as ready for review November 10, 2023 09:10
@mrloop mrloop added the enhancement New feature or request label Nov 10, 2023
@mrloop mrloop merged commit 0c59539 into main Nov 10, 2023
16 checks passed
@michelegera michelegera deleted the update-fetch-to-include-credentials branch December 18, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants