feat: migrate phone-input component to glimmer #745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Hey @m-jovan thanks for this, nice job 🙏
Question: is this change breaking?
vscav
reviewed
Sep 27, 2023
|
Thanks for this @m-jovan, really nice! I did build and import the addon in one of our apps, and it's working like a charm 💯 |
m-jovan
force-pushed
the
glimmer-migration
branch
from
892a16a
to
a1f925f
Compare
|
@dannycalleri No breaking changes were introduced with this migration. Thanks for the review! @vscav Thanks for the review as well! |
|
@m-jovan Since it's not a breaking change, could you add the tag |
vscav
approved these changes
Sep 28, 2023
m-jovan
force-pushed
the
glimmer-migration
branch
from
a1f925f
to
07dfbc6
Compare
dannycalleri
approved these changes
Sep 28, 2023
vscav
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're migrating
phone-inputcomponent from classic Ember component to glimmer component as a prerequisite for introducing Typescript to this addon.Unfortunately we could not avoid using render modifiers since there are conflicts between using native glimmer lifecycle methods and the
intl-tel-inputlib that we are wrapping due to its manual dom manipulation of our input.Component files have been collocated to components folder in order for glimmer to be able to render properly.