Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrap unsafe component invocation with ensure-safe-component #22

Merged
merged 3 commits into from
May 26, 2023

Conversation

poulet42
Copy link
Contributor

@poulet42 poulet42 commented May 25, 2023

Following these guidelines this MR adds the ensure-safe-component to a dynamic component invocation.

Note, I do not pass custom components as strings anymore in the tests files, following these recommendations but it's still possible

@poulet42 poulet42 requested a review from mrloop May 25, 2023 09:25
@poulet42 poulet42 marked this pull request as draft May 25, 2023 09:39
@poulet42 poulet42 marked this pull request as ready for review May 25, 2023 11:29
@poulet42 poulet42 force-pushed the use-ensure-safe-comp branch 3 times, most recently from 5bba3f0 to 03ba4c8 Compare May 25, 2023 11:42
@mrloop
Copy link
Member

mrloop commented May 25, 2023

Note, I do not pass custom components as strings anymore in the tests files, following these recommendations but it's still possible

If we still support it we should test it, otherwise this is a breaking change and we need to bump the major version and document it.

@poulet42
Copy link
Contributor Author

Note, I do not pass custom components as strings anymore in the tests files, following these recommendations but it's still possible

If we still support it we should test it, otherwise this is a breaking change and we need to bump the major version and document it.

@mrloop I added an extra test passing custom component as a string :)

Copy link
Member

@mrloop mrloop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@poulet42 poulet42 merged commit f0d9e17 into qonto:main May 26, 2023
12 checks passed
@poulet42 poulet42 deleted the use-ensure-safe-comp branch May 26, 2023 12:14
@vscav vscav added the enhancement New feature or request label Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants