Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ng build --prod AOT compilation errors with fullTemplateTypeCheck: true #127

Open
KeithGillette opened this issue Mar 1, 2018 · 3 comments

Comments

@KeithGillette
Copy link

Angular 5.2 introduces a new AoT compiler fullTemplateTypeCheck option to perform a more thorough type check on templates. It is expected that this option will default to true in a future version: https://blog.angular.io/angular-5-2-now-available-312d1099bd81

Running ng build --prod with tsconfig.app.json updated with the template checks:

"angularCompilerOptions": {
  "fullTemplateTypeCheck": true
},

produces the following errors:

node_modules/@qontu/ngx-inline-editor/ngx-inline-editor.d.ts.InlineEditorComponent.html(1,579): : Argument of type '{ event: any; state: InlineEditorState; }' is not assignable to parameter of type 'ExternalEvent'.
  Types of property 'state' are incompatible.
    Type 'InlineEditorState' is not assignable to type 'InlineEditorStateOptions'.
      Property 'value' is private in type 'InlineEditorState' but not in type 'InlineEditorStateOptions'.
node_modules/@qontu/ngx-inline-editor/ngx-inline-editor.d.ts.InlineEditorComponent.html(1,769): : Argument of type '{ event: any; state: InlineEditorState; }' is not assignable to parameter of type 'ExternalEvent'.
  Types of property 'state' are incompatible.
    Type 'InlineEditorState' is not assignable to type 'InlineEditorStateOptions'.
  • InlineEditor: 0.2.0-alpha.12
  • Angular: 5.2.6
  • Angular CLI: 1.7.1
  • TypeScript: 2.7.2
  • Node.JS: 8.9.3
@KeithGillette
Copy link
Author

@xxxTonixxx — I made a brief attempt to diagnose & resolve this issue to offer a PR, but can't get the build script to run. The project doesn't seem to include @angular/cli in devDependencies. Any guidance?

@rovico
Copy link

rovico commented Jan 18, 2019

@KeithGillette how did you solve this proplem? Seems this project is dead....

@KeithGillette
Copy link
Author

I have no solution to this problem, as I have been waiting for the new build process promised by @xxxTonixxx before I return to attempting to implement a fix. Unfortunately, I agree that the project does seem moribund, @rovico, as I have not heard from the maintainers since September 2018.

rovico pushed a commit to rovico/ngx-inline-editor that referenced this issue Feb 11, 2019
…eed to change build process to update npm package
@KeithGillette KeithGillette mentioned this issue Apr 9, 2019
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants