Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix StackOverflowError in long Text Block by using non-capturing Atomic Group #81

Merged
merged 1 commit into from
Nov 16, 2020

Conversation

nieldw
Copy link
Contributor

@nieldw nieldw commented Nov 16, 2020

Fix StackOverflowError in very long Text Blocks by using non-capturing Atomic Group for inner group. The rest of the code only uses the first (info line) and second (outer text) groups. The repeating inner group is not used and is therefore replaced with a non-capturing group. This may also speed up parsing and reduce the memory footprint.

@qoomon
Copy link
Owner

qoomon commented Nov 16, 2020

thanks a lot

@qoomon qoomon merged commit 3df6a82 into qoomon:master Nov 16, 2020
@qoomon
Copy link
Owner

qoomon commented Nov 16, 2020

released by version 1.4.4

@nieldw nieldw deleted the fix/parse_very_long_text_blocks branch November 16, 2020 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants