Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme: Proxy-passed configuration doesn't work correctly #748

Closed
gnadelwartz opened this issue May 3, 2017 · 16 comments
Closed

Theme: Proxy-passed configuration doesn't work correctly #748

gnadelwartz opened this issue May 3, 2017 · 16 comments
Labels

Comments

@gnadelwartz
Copy link
Contributor

using webmin 1.831 (latest) and usermin 1.701 (latest) on SuSE Linux leap 42.1
the latest release and develop versions of the theme can not save theme user options because a missing script in usermin:

usermin/save_config.cgi

is the github version webmin only? IMHO it should work also with usermin...

@gnadelwartz gnadelwartz changed the title script for saving user options fro them is not availible in Usermin script for saving user options for theme is not availible in Usermin May 3, 2017
@iliajie
Copy link
Collaborator

iliajie commented May 3, 2017

Not sure what you mean.

@gnadelwartz
Copy link
Contributor Author

gnadelwartz commented May 3, 2017

bildschirmfoto vom 2017-05-03 12-56-13
bildschirmfoto vom 2017-05-03 12-58-58

URL of frame: https://mail.rrr.de/usermin/save_config.cgi

my gues is it is this line in settings-user.cgi:
print ui_form_start( "save_config.cgi", "post", undef, 'id="settings_"' )

@iliajie
Copy link
Collaborator

iliajie commented May 3, 2017

Do you also have latest theme for Usermin?

@gnadelwartz
Copy link
Contributor Author

I'm not shure what you mean ... I have installed lastet usermin 1.701 from here http://www.webmin.com/usermin.html

It contains authentic theme 17.72 (working but without theme options) and updated to 18.47 which gave me this error.

Is there a seperate theme repository for usermin?

@iliajie
Copy link
Collaborator

iliajie commented May 3, 2017

I think you suffering from stuck browser's cache.

That form link is irrelevant and can be anything. Hard reload browser's cache and the issue will go away.

After you hit the button, the form will be submitted in background.

@iliajie iliajie closed this as completed May 3, 2017
@gnadelwartz
Copy link
Contributor Author

found the issue!

it is not because of browser cache, it is because I proxy webmin via apache as described here in the second section: http://www.webmin.com/uapache.html and webprefix=/usermin set in usermin/config

wenn I access webmin via localhost:20000 it is working

Whats interessting is than I have setup webmin in the same way, and there is no problem ...

@iliajie iliajie reopened this May 3, 2017
@gnadelwartz gnadelwartz changed the title script for saving user options for theme is not availible in Usermin saving user options for theme is not working in Usermin with proxy via apache May 3, 2017
@iliajie
Copy link
Collaborator

iliajie commented May 6, 2017

If you run in the browser's console:

$webprefix_full

What do you get on the output?

@iliajie
Copy link
Collaborator

iliajie commented May 6, 2017

Are there errors in the browser's console?

@gnadelwartz
Copy link
Contributor Author

No errors in console:

("Welcome to Authentic Theme 18.47-git-201705061059
https://github.com/qooob/authentic-theme"  parent.min.js:6:169
"nsICookieManager2.getCookiesFromHost()" wurde verändert. Aktualisieren Sie Ihren Code und übergeben Sie die korrekten originAttributes. Lesen Sie mehr auf MDN: https://developer.mozilla.org/docs/Mozilla/Tech/XPCOM/Reference/Interface/nsICookieManager2  cookietracker.js:126:12
)

>> $webprefix_full
<- "/usermin"

@iliajie
Copy link
Collaborator

iliajie commented May 6, 2017

Can you try in incognito mode or disable all of your browser's add-ons?

@gnadelwartz
Copy link
Contributor Author

gnadelwartz commented May 6, 2017

nothing changed, same issue

may be add an option to disable theme preference in usermin...

@iliajie
Copy link
Collaborator

iliajie commented May 6, 2017

You can hide preferences for your users with ease using theme's extensions (js) but this is not what you want. Users need to change settings, like colors and stuff. That was the whole point of enrolling it into 18.4x.

Don't know what might be causing an issue.

Are you sure that you have set up your proxy correctly. Are they configured identically with Webmin?

It's the same code for both Webmin and Usermin - they shouldn't be working differently.

@iliajie
Copy link
Collaborator

iliajie commented May 6, 2017

Funny, I could reproduce an error using proxy pass. Brr..

Will try to figure this out.

@iliajie
Copy link
Collaborator

iliajie commented May 6, 2017

Actually it caused whole lot of UI issues that were left unnoticed for long time.

For example, try going to Running Processes to see what I mean.

It will be fixed on the next commit.

@iliajie iliajie changed the title saving user options for theme is not working in Usermin with proxy via apache Theme: Proxy-passed configuration doesn't work correctly May 6, 2017
@iliajie iliajie added the bug label May 6, 2017
@iliajie
Copy link
Collaborator

iliajie commented May 6, 2017

Thank you very much for reporting!

Please test.

@iliajie iliajie closed this as completed May 6, 2017
@gnadelwartz
Copy link
Contributor Author

saving options is working now!
thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants