Theme: Authentic Theme moving to the next level with 19.00+ #807

iliajie · 2017-05-30T14:25:33Z

Hi,

I have just added Authentic Theme 19.00-RC1.

gnadelwartz · 2017-07-22T14:48:15Z

in my setup only the webmin categorie modules was working, but e.g. Apache module and all others gave me an error like /usr/libexec/somecgi.cgi..../apache not found. note the 4 dots.

additionally the system timeon dashboard is shown twice

so i reverted to 18.49-8

iliajie · 2017-07-22T14:50:06Z

Hi,

Are you behind proxy?

gnadelwartz · 2017-07-22T14:55:41Z

of course 😎, but can't test non proxy because i'm on vacation and have only my tablet with me

Tantawi · 2017-07-24T06:54:42Z

I have the second issue (system time showing twice on dashboard, one linking to /time and the other beside it in black, none linked), plus:

1- Checking for packages updates by clicking the refresh icon on the dashboard does nothing, no errors in console and no Ajax requests are made.

2- If I click on "All installed packages are up to date" and click on "Refresh available packages" button, it works but the browser moves to "/package-updates/update.cgi?mode=updates&search=&refresh=Refresh+Available+Packages" and the side menu disappears.

3- System -> Software packages -> "Search for package:" does nothing again, no console errors or AJAX requests made.

This is tested on Chrome Dev 61 on Windows 10 and macOS, without any proxies or VPNs.

Otherwise, this is almost perfection! :)

iliajie · 2017-07-24T07:43:35Z

Mohamed, hi!

Thank you for your comments. I'm aware of those problems. At the moment, I need to find out how to get progressive output using jQuery.

There are other issues with File Manager and ConfigServer Security & Firewall modules. They don't work as SPA yet. There is so much code to review/rewrite.

I'm working on it ..

I'm looking forward (eager really) to start enrolling new features but I'm stuck with this stuff. (but I find this vital, so I'm not really complaining.. just has to be done..)

tpnsolutions · 2017-07-25T09:26:04Z

Another cosmetic issue I just discovered in RC1.

When you create a "Virtual Server", the left and right sidebars disappear.

iliajie · 2017-07-25T10:09:40Z

You mean you are taken to the separate page? Well yes, RC1 doesn't have progressive output support.

Thanks Peter for looking into it.

iliajie · 2017-07-31T19:36:14Z

RC Release Notes:

Version 19.00-RC2 (July 31, 2017)

Added support for proressive output (buffered header)
Added system information is now being recollected using native recollect.cgi script
Fixed theme post save actions to refresh navigation menu properly on server request
Fixed failed to load modules that can accept multiple methods, for example Command Shell
Fixed navigation menu detection for module configuration pages
Fixed pie-chart displayed incorrectly after going to theme's settings #825
Fixed time displayed incorrectly on System Information page #825

tpnsolutions · 2017-07-31T19:59:44Z

# 19.00-RC2

* This is just a cosmetic issue, likely an oversight and pretty minor. *

When you click "Logs and Reports > Apache Error Log" the left navigation highlights "Apache Access Log".

* This is just a cosmetic issue, likely a simple fix *

When you click "Logs and Reports > Apache Access Log", the page show a clean, themed log entry text area.

However, when you click the "refresh" button on the page, it seems to lose it's styling.

* This is a possible improvement to the "Logs and Reports" area *

Instead of having to "manually" refresh the pages, wouldn't it be nifty to have say a "start" and "pause" button where you could asynchronously refresh the log in near real-time similar to issuing a "tail -f" on the command line. The purpose of having a "start" and "pause" button is so people can still decide whether they want to monitor the log, or simply see the last X amount of lines.

iliajie · 2017-07-31T21:23:13Z

Yes, I like this idea so much. I will add this toggle. .. and fix the bug..

..please, please - keep digging. I need it.

Tantawi · 2017-07-31T21:41:35Z

Great progress! thanks a lot. One cosmetic bug in RC2, Chrome v61 on Windows 10:

1- My server is running Ubuntu 16.04 and I have installed smartmontools package (to display hard drive temps on dashboard, I have three).
2- Upon login, or manual page refresh on the dashboard, "Drive temperatures" will flash for a split second then disappear.
3- Clicking the Dashboard icon from the navigation will make Drive temperatures display and stick, as normal.

iliajie · 2017-07-31T21:52:34Z

Thanks, I will fix it all in RC3.

Tantawi · 2017-08-03T08:59:46Z

One more error: Trying to set auto checking for packages updates to every hour, entering an email for reporting, and choosing "Install any updates", then clicking "Save" outputs a lot of JavaScript errors in the browser console and nothing is saved.

iliajie · 2017-08-03T16:21:16Z

Thanks @Tantawi I will take a look! 😉

iliajie · 2017-08-15T20:37:59Z

RC3 is available. Please give it a try!

@tpnsolutions Peter, new features with log auto-update will be enrolled later. It's on my to-do.

iliajie · 2017-08-19T09:50:38Z

Nothing to add or say about RC3? 😉

tpnsolutions · 2017-08-19T18:00:04Z

@qooob just installed RC3.

Started to navigate to each of the pages in the UI, and came across the first bug.

"Webmin > Others > File Manager" takes you to a "separate page" without the basic UI wrapped around it.

tpnsolutions · 2017-08-19T18:05:53Z

@qooob another bug, related to former.

"Virtualmin > Edit Web Content" opens in "new tab" and "separate page" without basic UI wrapped around it.

*** underlying issue appears to be related to "Filemin" integration ***

tpnsolutions · 2017-08-19T18:08:16Z

@qooob another bug found.

"Virtualmin > Logs and Reports > Apache Error Log" triggers "Apache Access Log" to be highlighted in left menu instead of "Apache Error Log".

tpnsolutions · 2017-08-19T18:09:48Z

@qooob another bug, related to former.

"Virtualmin > Services > Configure Website for SSL" triggers "Configure Website" to be highlighted in left menu instead of "Configure Website for SSL".

iliajie · 2017-08-19T18:09:58Z

Thanks, Peter. File Manager is still not working in RC3.

About Error Log and Website for SSL not being highlighted - confirmed.

gnadelwartz · 2017-08-20T15:51:19Z

When do you expect to have a working File Manager?

iliajie · 2017-09-23T06:40:53Z

Peter, I will add the requested functionality (about automatic log refresh using timeout) to final release of version 19.00 very soon.

This is how the page is going to look like.

Video-screencast.

gnadelwartz · 2017-09-25T08:41:28Z

Hi,

RC10 works now like a charm: It's fast and stable :-)

Only the problem with my Majordomo Config Button cycling forever remains.
In case you did not get my anser to your PN:

I have a link to download majordomo in config dialog of the module (first aid section), its a working majordomo with all oatches applied.

Direct link: http://files1.directadmin.com/services/es_7.0_64/majordomo-1.94.5-patched.tar.gz

The module I'M using is from the official repository:

Description | Create and configure mailing lists for Majordomo version 1.94.
Download | http://www.webmin.com/webmin/download/modules/majordomo.wbm.gz
Website | http://www.webmin.com/webmin/standard.html
Author | Jamie Cameron
Last updated | 2017-06-25 23:32:19

iliajie · 2017-09-25T10:18:25Z

Kay, I remember about your request. Your email is staying marked in my inbox. I will do it before the initial release or at most in 19.01. 😉

gnadelwartz · 2017-09-30T10:56:25Z

anything new? e.g. RC11?

iliajie · 2017-09-30T10:57:23Z

Doing final release within 4 hours. Later comeback to the smaller issues. So much to do!

gnadelwartz · 2017-09-30T11:00:41Z

sounds good! thanks for your work!
If you ever visit germany I have to spend you a beer (wine/whisky) or two!

iliajie · 2017-09-30T11:01:16Z

I would love to. Thanks. 😉

iliajie · 2017-09-30T16:48:11Z

Version 19.00 is finally released. ✨

Enjoy.

Zen4All · 2017-09-30T18:36:52Z

🎆 Awesome. I have been following this in surveillance mode, but I really appreciate all the effort you put in to this.

iliajie · 2017-09-30T19:41:27Z

Well, thank you for your kind words.

7starsone · 2017-09-30T21:34:45Z

Hello, when will the update be available on the System Information page? Thanks

iliajie · 2017-09-30T21:46:36Z

A bit later. Just force update from theme settings.

7starsone · 2017-09-30T21:55:10Z

first issue on navigation
example: click on Webmin→Servers→Dovecot...
at this point, if you click on System→Log File Rotation...
it remains on the Dovecot page, it doesn't change page

7starsone · 2017-09-30T22:00:06Z

i get this on console:
POST https://mydomain.com:10000/logrotate/ net::ERR_CONNECTION_RESET
from bundle.min.js

iliajie · 2017-10-01T18:36:08Z

I can not reproduce this. It works for me as expected. Do you have console opened or closed when you were testing it? (just asking)

What is your system information for server and client?

7starsone · 2017-10-02T07:14:17Z

also cleared cache, logged out... it's the same
Server CentOS 7.3.1611 64bit
Client Windows 10, Chrome 61.0.3163.100 64bit, no matter if you keep the console open or closed...

on the address bar I get
https://mydomain.com:10000/logrotate/?xnavigation=1

but on the center page the Dovecot page remains...
and this is just an example, it seems that it happens with random pages too

7starsone · 2017-10-02T08:00:56Z

something else I've noticed in this case...
on the center page, if i'm on a Dovecot button (eg. SSL Configuration), it retrieves the URL from the Log Rotate module but the viewed page is from Dovecot....

<div class="col-xs-1 icons-container forged-xx-skip grayscaled animated" data-original-title="" title=""><a href="edit_ssl.cgi" class="icon_link" data-title="" data-toggle="tooltip" data-placement="auto bottom" data-container="body" data-original-title="" title=""><img class="ui_icon ui_icon_protected" src="/images/modules/dovecot/ssl.gif" alt=""><br>SSL Configuration</a>
</div>

here it becomes https://mydomain.com:10000/logrotate/edit_ssl.cgi
so still a little fuzzy

iliajie · 2017-10-02T08:04:01Z

I have three different, physical machines with different OSes and browsers. I can not reproduce it.

Can anyone else reading it reproduce it? Please be kind giving new release a try.

iliajie · 2017-10-02T08:05:13Z

@7starsone Try in incognito mode please.

7starsone · 2017-10-02T08:14:09Z

in incognito it works, in normal mode, instead, it doesn't work as expected even if all extensions are disabled
first I tried one by one, then disabled all the extensions and the issue on Chrome comes back...

not tried with other browsers

7starsone · 2017-10-02T08:16:59Z

maybe a problem with cookies?

iliajie · 2017-10-02T08:19:45Z

In non-incognito mode, open console and then hold refresh button, then select 3 option. Does it help?

7starsone · 2017-10-02T08:21:43Z

ok, it's a cookie issue. Guys, if you update from the 18.49...

you need to clear all cache and cookies from browser, otherwise you have this issue

iliajie · 2017-10-02T08:32:25Z

@7starsone I'm glad it helped but i don't think it has anything to do with cookies itself but rather, it's the cache issue.

7starsone · 2017-10-03T08:05:40Z

please, take a look at virtualmin/virtualmin-gpl#16
thanks

iliajie · 2017-10-10T12:38:15Z

@gnadelwartz Speaking about your non-submitting form. It's required to be fixed on the Perl side.

Make sure that the form contains the actual button. There is a fix for crazy forms/buttons but it doesn't cover all cases, and actually shouldn't.

You could refer to the following commits that fixes exactly the same problem for other modules.

webmin/webmin@344819f
webmin/webmin@344819f

gnadelwartz · 2017-10-10T14:49:15Z

ill have a look

gnadelwarty · 2017-10-10T16:57:37Z

found the problem webmin/webmin#651

iliajie added enhancement help wanted labels May 30, 2017

Repository owner deleted a comment from 7starsone Jul 15, 2017

Repository owner deleted a comment from sinankizar Jul 15, 2017

Repository owner deleted a comment from tpnsolutions Jul 15, 2017

iliajie mentioned this issue Jul 24, 2017

Cosmetic Bugs #825

Closed

iliajie mentioned this issue Sep 19, 2017

Fix login redirect from FQDM/webmin webmin/webmin#627

Open

iliajie closed this as completed Sep 30, 2017

Theme: Authentic Theme moving to the next level with 19.00+ #807

Theme: Authentic Theme moving to the next level with 19.00+ #807

Comments

iliajie commented May 30, 2017 • edited

gnadelwartz commented Jul 22, 2017 • edited

iliajie commented Jul 22, 2017

gnadelwartz commented Jul 22, 2017 • edited

Tantawi commented Jul 24, 2017 • edited

iliajie commented Jul 24, 2017

tpnsolutions commented Jul 25, 2017

iliajie commented Jul 25, 2017

iliajie commented Jul 31, 2017 • edited

RC Release Notes:

Version 19.00-RC2 (July 31, 2017)

tpnsolutions commented Jul 31, 2017 • edited

*** This is just a cosmetic issue, likely an oversight and pretty minor. ***

*** This is just a cosmetic issue, likely a simple fix ***

*** This is a possible improvement to the "Logs and Reports" area ***

iliajie commented Jul 31, 2017 • edited

Tantawi commented Jul 31, 2017

iliajie commented Jul 31, 2017 • edited

Tantawi commented Aug 3, 2017 • edited

iliajie commented Aug 3, 2017

iliajie commented Aug 15, 2017

iliajie commented Aug 19, 2017

tpnsolutions commented Aug 19, 2017

tpnsolutions commented Aug 19, 2017

tpnsolutions commented Aug 19, 2017

tpnsolutions commented Aug 19, 2017

iliajie commented Aug 19, 2017 • edited

gnadelwartz commented Aug 20, 2017 • edited by iliajie

iliajie commented Sep 23, 2017 • edited

gnadelwartz commented Sep 25, 2017

iliajie commented Sep 25, 2017

gnadelwartz commented Sep 30, 2017

iliajie commented Sep 30, 2017

gnadelwartz commented Sep 30, 2017

iliajie commented Sep 30, 2017

iliajie commented Sep 30, 2017

Zen4All commented Sep 30, 2017

iliajie commented Sep 30, 2017

7starsone commented Sep 30, 2017

iliajie commented Sep 30, 2017

7starsone commented Sep 30, 2017

7starsone commented Sep 30, 2017 • edited

iliajie commented Oct 1, 2017

7starsone commented Oct 2, 2017 • edited

7starsone commented Oct 2, 2017

iliajie commented Oct 2, 2017

iliajie commented Oct 2, 2017

7starsone commented Oct 2, 2017 • edited

7starsone commented Oct 2, 2017

iliajie commented Oct 2, 2017 • edited

7starsone commented Oct 2, 2017

iliajie commented Oct 2, 2017

7starsone commented Oct 3, 2017

iliajie commented Oct 10, 2017

gnadelwartz commented Oct 10, 2017

gnadelwarty commented Oct 10, 2017

iliajie commented May 30, 2017 •

edited

gnadelwartz commented Jul 22, 2017 •

edited

gnadelwartz commented Jul 22, 2017 •

edited

Tantawi commented Jul 24, 2017 •

edited

iliajie commented Jul 31, 2017 •

edited

tpnsolutions commented Jul 31, 2017 •

edited

* This is just a cosmetic issue, likely an oversight and pretty minor. *

* This is just a cosmetic issue, likely a simple fix *

* This is a possible improvement to the "Logs and Reports" area *

iliajie commented Jul 31, 2017 •

edited

iliajie commented Jul 31, 2017 •

edited

Tantawi commented Aug 3, 2017 •

edited

iliajie commented Aug 19, 2017 •

edited

gnadelwartz commented Aug 20, 2017 •

edited by iliajie

iliajie commented Sep 23, 2017 •

edited

7starsone commented Sep 30, 2017 •

edited

7starsone commented Oct 2, 2017 •

edited

7starsone commented Oct 2, 2017 •

edited

iliajie commented Oct 2, 2017 •

edited