Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme: Drop hardcoded reference to theme's directory #812

Closed
v1nce opened this issue Jun 1, 2017 · 2 comments
Closed

Theme: Drop hardcoded reference to theme's directory #812

v1nce opened this issue Jun 1, 2017 · 2 comments

Comments

@v1nce
Copy link

v1nce commented Jun 1, 2017

As authentic-theme seem to be the theme of choice for webmin, this is the one I choosed to try to tweak it [*] a bit. So I started to clone the theme (without breaking current installation).
I just exported the theme using webmin. Unzipped the theme.gz. change name of the holding directory. Edit the theme.info to change the name and zipped it back.
I managed to import it back but it is not working. I got messages about file missing.
I guess it's because there are hardcoded reference to "authentic-theme" in a lot of cgi.

It looks to me like there was some attempt to use a var for the theme directory ($config_directory . "/" . $current_theme)

How difficult would it be (for a total newbie) to replace the hardcoded references ?
If I patched the authentic.pm, authentic-init.pm and authentic-lib.pm would I get a minimal working webmin ? (minimal = UI + dashboard are working ; some modules may crash)

[*] I want to add xhr whenever this is possible and generate most (all ?) of the UI on the client side.

@iliajie
Copy link
Collaborator

iliajie commented Jun 1, 2017

Yes, this is the current drawback. I've started on working on completely renewed version 19.00. I will try to make sure that the path is not hardcoded there.

Meanwhile, I don't know how hard it would be. Probably replacing authentic-theme with $current_theme should do the work.

@iliajie iliajie changed the title hardcoded references to theme directory make it difficult to 'clone' Theme: Drop hardcoded reference to theme's directory Jun 1, 2017
@iliajie
Copy link
Collaborator

iliajie commented Sep 14, 2017

It will be added to 19.00-RC9 about tomorrow.

Thanks.

@iliajie iliajie closed this as completed Sep 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants