Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme: Produce user-friendly message in case server can't be reached #846

Closed
Sopor opened this issue Oct 6, 2017 · 8 comments
Closed

Theme: Produce user-friendly message in case server can't be reached #846

Sopor opened this issue Oct 6, 2017 · 8 comments

Comments

@Sopor
Copy link
Contributor

Sopor commented Oct 6, 2017

I shutdown one of my computers running Webmin 1.850 but i did it from a terminal window. So now i see this green square with a spinning arrow and it seems to never stops. Shouldn't there be some kind of timeout and a message that told me that the server is not reachable?

I'm running Authentic Theme 19.00-git-201710041248 in Firefox 56.

@iliajie
Copy link
Collaborator

iliajie commented Oct 8, 2017

It would be user friendly, sounds like an enhancement.

@iliajie iliajie changed the title shutdown - green square with a spinning arrow and it never stops Theme: Produce user-friendly message in case server can't be reached Oct 8, 2017
@iliajie
Copy link
Collaborator

iliajie commented Nov 15, 2017

I've added this functionality.

Here is example message:

screenshot from 2017-11-15 14-33-53

But that's not all. I'm in the process of adding pop-up authentication screen to let user authenticate without actually going back to login screen.

#892

@iliajie iliajie closed this as completed Nov 15, 2017
@swelljoe
Copy link

The English in the first suggestion isn't quite right.

Something like "Check if the server is running".

Also, the message about "the proxy and the firewall" will definitely confuse someone. I guarantee we'll get a ticket from someone saying, "But I don't have a proxy!" Maybe just as ", if any" to the end of that one.

@iliajie
Copy link
Collaborator

iliajie commented Nov 15, 2017

I will drop the last and the first one been changed already to "Check server status".

If you think latter is still not good, let me know.

@Sopor
Copy link
Contributor Author

Sopor commented Nov 27, 2017

@qooob is it possible to add a retry/reload/try again button to the connection error dialog?

@iliajie
Copy link
Collaborator

iliajie commented Nov 27, 2017

Yes, in automated mode with, using ticking timeout, would be better than a button, right?

@Sopor
Copy link
Contributor Author

Sopor commented Nov 27, 2017

In that case both.
I was waiting for the server to start so i have to close the dialog, press the Dashboard button, the dialog popped up again, close the dialog, press Dashboard again...
If you only add a timeout i can't force it :(

@iliajie
Copy link
Collaborator

iliajie commented Dec 16, 2017

It's been fixed.

51127a1

Give it a try. Go to console and run /etc/webmin/stop ... then after a while, run /etc/webmin/start.

Example in video-screencast of how it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants