Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authentic 19.00 don't show caption in tabs #853

Closed
sz00gun opened this issue Oct 9, 2017 · 25 comments
Closed

Authentic 19.00 don't show caption in tabs #853

sz00gun opened this issue Oct 9, 2017 · 25 comments

Comments

@sz00gun
Copy link

sz00gun commented Oct 9, 2017

Theme: Authentic Theme 19.00-git-201710041248
Ubuntu Linux 16.04.2

The bug: please have a look a screen shot:
bug

PS. how to remove those errors?

@iliajie
Copy link
Collaborator

iliajie commented Oct 9, 2017

Clear cache and reload the theme.

@sz00gun
Copy link
Author

sz00gun commented Oct 10, 2017

Off course I have done it. I purged a cache from the browser, also have a fresh theme installation, I tried beta and stable version. Versions previous than 19 works fine.

@iliajie
Copy link
Collaborator

iliajie commented Oct 10, 2017

What is your browser?

@sz00gun
Copy link
Author

sz00gun commented Oct 10, 2017

This is not working in Firefox and Chrome

@iliajie
Copy link
Collaborator

iliajie commented Oct 10, 2017

Get the latest git version to test it. It's fixed.

@iliajie iliajie closed this as completed Oct 10, 2017
@sz00gun
Copy link
Author

sz00gun commented Oct 10, 2017

Unfortunately a bug still there... ;(

@iliajie
Copy link
Collaborator

iliajie commented Oct 10, 2017

Yes, I know. Just also noticed it.

@iliajie
Copy link
Collaborator

iliajie commented Oct 10, 2017

Will try fixing it upon next commit.

@iliajie
Copy link
Collaborator

iliajie commented Oct 10, 2017

Go to theme settings, pull latest commit, clear browser's cache forcefully and try again.

It works on my server that also gave an error, should also work on yours.

@sz00gun
Copy link
Author

sz00gun commented Oct 10, 2017

What is the latest patch? My server recognises: Authentic Theme 19.00-git-201710101341 only

PS. just different quick question:

could you consider to change the code by pressing RBM on the Webmin or Virtualmin on left top to show the Open Link in new tab. I just get used to. Or just by pressing RBM on it to open a new cart with Virtualmin - it was before, not in 19v.

@iliajie
Copy link
Collaborator

iliajie commented Oct 10, 2017

Just force update using settings. It's not pushed to updates yet.

I'm not sure what you were asking, could you rephrase the question please.

1 similar comment
@iliajie
Copy link
Collaborator

iliajie commented Oct 10, 2017

Just force update using settings. It's not pushed to updates yet.

I'm not sure what you were asking, could you rephrase the question please.

@sz00gun
Copy link
Author

sz00gun commented Oct 10, 2017

  1. I force re installed it by:
    install

  2. How to quick open a new tab with virtualmin?
    wirt

@iliajie
Copy link
Collaborator

iliajie commented Oct 11, 2017

At first, you never said anything about captions on the right slider?

I will add the ability to open new window from the switch later.

@sz00gun
Copy link
Author

sz00gun commented Oct 11, 2017

  1. Yes the original of the bug was: captions on the right slider,

  2. That open in new window is another minor issue, I just didn't want to open a new ticket.

@sz00gun
Copy link
Author

sz00gun commented Oct 11, 2017

Works now... better than before, however still not in 100%. Please have a look a screen cast:
https://screencast-o-matic.com/watch/cb6X2JIEuS

@iliajie
Copy link
Collaborator

iliajie commented Oct 11, 2017

It's obviously in theme's settings. You can enable/disable any tab you want. Check for Side slider options.

@sz00gun
Copy link
Author

sz00gun commented Oct 11, 2017

Settings are fine, all tabs should be visible all the time, please again, have a look: https://screencast-o-matic.com/watch/cb6XqAIEdw

@iliajie
Copy link
Collaborator

iliajie commented Oct 11, 2017

Interesting. What browser is that?

@sz00gun
Copy link
Author

sz00gun commented Oct 11, 2017

Latest Firefox, however latest chrome works the same like the Fox

@iliajie
Copy link
Collaborator

iliajie commented Oct 11, 2017

Confirmed, thanks a lot. 😉

@iliajie
Copy link
Collaborator

iliajie commented Oct 12, 2017

Fixed in the commit above.

@iliajie
Copy link
Collaborator

iliajie commented Oct 12, 2017

Also added opening current page into new tab:
#853 (comment)

You would have to allow popup for your domain.

@sz00gun
Copy link
Author

sz00gun commented Oct 12, 2017

allow popup for the domain works, but not as before, and not as it should be, because a new window don't contain a right slider, and left menu. ;(

@iliajie
Copy link
Collaborator

iliajie commented Oct 12, 2017

It will contain it, after Jamie adds my patch to the next Webmin release.

You can do it manually:
webmin/webmin#652

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants