Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File Manager: Text editor refresh not working #869

Closed
Abasz opened this issue Oct 25, 2017 · 15 comments
Closed

File Manager: Text editor refresh not working #869

Abasz opened this issue Oct 25, 2017 · 15 comments

Comments

@Abasz
Copy link

Abasz commented Oct 25, 2017

Recently I noticed that in case I try to refresh the opened file in the file editor (from the dropdown) it breaks.

After that I am not able to open a file with the editor until I enter localstorage.Clear()

Below is a video I made with the error:

ScreenCast

I am behind proxypass accessing webmin via https://IP/webmin/

@iliajie
Copy link
Collaborator

iliajie commented Oct 26, 2017

I don't think it's the theme issue.

Try disabling ADB and other extensions.

I have it working fine, take a look at the video-screencast.


A note. Did you try to hit Alt when the dropdown menu in editor is opened to see what happens? 😃

@Abasz
Copy link
Author

Abasz commented Oct 26, 2017

This is not a big issue, I do not know the error behind. disabling ADB does not help.

I never tried before (but now I have :)) but what should happen when you press Alt? (the only change I can see is that the window layout of the editors may be change, however, if I press Alt once and I release I need to close and reopen the drop down to work again)

@iliajie
Copy link
Collaborator

iliajie commented Oct 26, 2017

I can't reproduce your issue. You saw the video-screencast.

What do you think could cause it?

In case you're in the file editor in File Manager, when you click on the dropdown menu and it stays open, try hitting Alt key to see that menu content will change letting you choose to align panels differently.

@iliajie
Copy link
Collaborator

iliajie commented Oct 26, 2017

..also try incognito mode..

@Abasz
Copy link
Author

Abasz commented Oct 26, 2017

Hi, Alt key works as expected in this regard (i.e. I can choose to align )

I was trying to the a breakpoint debug (to find out where things go wrong) but to be honest I was not able to find the related javascript part (I fudn the ). If you could point me to the direction where the related script is I will try to find out more.

@iliajie
Copy link
Collaborator

iliajie commented Oct 26, 2017

Do you see errors in the console?

@Abasz
Copy link
Author

Abasz commented Oct 26, 2017

No I dont. I think this would not create a console error since text is loaded but the wrong one (part of the page Html code is loaded). So it seems that instead of text area the first lines of the html file is read into the panel

@iliajie
Copy link
Collaborator

iliajie commented Oct 26, 2017

What is your browser and OS (server and client)?

@Abasz
Copy link
Author

Abasz commented Oct 26, 2017

OS server: Ubuntu server 16.04
OS Client: Win10
Browser: latest chrome

@iliajie
Copy link
Collaborator

iliajie commented Oct 26, 2017

Okay, what kind of error page is that? It's error page loaded? What does it say at the bottom of the screen?

@Abasz
Copy link
Author

Abasz commented Oct 27, 2017

I found the problem... It is actually very funny :)

the issue is that I use a webmin user name that does not exist on my system. If I change to username to e.g. root it works.

So I can create a unix user for my current webmin username, or I can change the current webmin user name to something that does exist on the system. This may be easier than changing the code around.

@Abasz
Copy link
Author

Abasz commented Oct 27, 2017

Or, off course the code may be changed :)

@iliajie
Copy link
Collaborator

iliajie commented Oct 27, 2017

That's really cool. 😆 I reproduced it.. Let's see what I should do.

@iliajie
Copy link
Collaborator

iliajie commented Oct 27, 2017

Fixed, give it a try.

@iliajie iliajie closed this as completed Oct 27, 2017
@Abasz
Copy link
Author

Abasz commented Oct 27, 2017

Nice one, seems working correctly. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants