-
-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Theme: Make accordions clickable #878
Comments
Hi, This is why I implemented the filter and expand all on top right. Yes, clicking on the accordion body should also just work, I agree. I will change accordion's behavior. |
Give it a try. |
One question @qooob, why is the |
I also noticed that if i collapse them all, expand one of them and i then press the expand button they all expand but if i have them all expanded and i collapse one of them and i now press the expand button they all expand instead of collapse. So now i have to press the expand button one more time to collapse them. |
@Sopor- I left it on purpose being working only half way. I was wondering, if there would be anybody who would notice that. I honestly doubted it. You did it! Great level of pickiness. I will fix it on the upcoming commits. We don't need two buttons for it. The toggle logic should be improved. About Theme Settings and Side slider options being expanded by default .. :) Well, it should be Global options but you obviously don't have Default pages. I will also fix that. Thanks. 2 improvements to be made. |
Give it a try. |
Hmm, i'm not sure i like it... If all menus are expanded and i press one of them, they all closes. Shouldn't that one i press continues to be open and all the others should close? Global options will now be expanded when I open the page. That is correct, yes? |
2.Global will be opened by default. That was the initial intent. 1.Damn it. It's not intended. 🪲 |
Fixed finally. 🤞 |
I notice you have changed the theme configuration but when i want to expand a menu it would be nice if i can do that by clicking on the line and not only the text. The text have different length so the click point is different on every line and this make it annoying.
Btw, is it possible to turn this new look off? Sometime you want to see all the settings :)
The text was updated successfully, but these errors were encountered: